Skip to content

Commit

Permalink
unsigned fid->fid cannot be negative
Browse files Browse the repository at this point in the history 
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
  • Loading branch information
Roel Kluin authored and Eric Van Hensbergen committed Nov 5, 2008
1 parent 1558c62 commit 9f3e9bb
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions net/9p/client.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ p9_client_rpc(struct p9_client *c, int8_t type, const char *fmt, ...)

static struct p9_fid *p9_fid_create(struct p9_client *clnt)
{
int err;
int ret;
struct p9_fid *fid;
unsigned long flags;

Expand All @@ -617,11 +617,12 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt)
if (!fid)
return ERR_PTR(-ENOMEM);

fid->fid = p9_idpool_get(clnt->fidpool);
ret = p9_idpool_get(clnt->fidpool);
if (fid->fid < 0) {
err = -ENOSPC;
ret = -ENOSPC;
goto error;
}
fid->fid = ret;

memset(&fid->qid, 0, sizeof(struct p9_qid));
fid->mode = -1;
Expand All @@ -638,7 +639,7 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt)

error:
kfree(fid);
return ERR_PTR(err);
return ERR_PTR(ret);
}

static void p9_fid_destroy(struct p9_fid *fid)
Expand Down

0 comments on commit 9f3e9bb

Please sign in to comment.