Skip to content

Commit

Permalink
V4L/DVB (11329): Fix buglets in v4l1 compatibility layer
Browse files Browse the repository at this point in the history
The following patch fixes a few bugs I've noticed in the V4L1
compatibility layer:
- VIDEO_MODE_AUTO for get/set input ioctls was not being handled
- wrong V4L2 ioctl being used in v4l1_compat_select_tuner

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Russell King authored and Mauro Carvalho Chehab committed Apr 7, 2009
1 parent 80801da commit 9fc4d21
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/media/video/v4l1-compat.c
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,8 @@ static noinline long v4l1_compat_get_input_info(
chan->norm = VIDEO_MODE_NTSC;
if (sid & V4L2_STD_SECAM)
chan->norm = VIDEO_MODE_SECAM;
if (sid == V4L2_STD_ALL)
chan->norm = VIDEO_MODE_AUTO;
}
done:
return err;
Expand All @@ -601,6 +603,9 @@ static noinline long v4l1_compat_set_input(
case VIDEO_MODE_SECAM:
sid = V4L2_STD_SECAM;
break;
case VIDEO_MODE_AUTO:
sid = V4L2_STD_ALL;
break;
}
if (0 != sid) {
err = drv(file, VIDIOC_S_STD, &sid);
Expand Down Expand Up @@ -804,9 +809,9 @@ static noinline long v4l1_compat_select_tuner(

t.index = tun->tuner;

err = drv(file, VIDIOC_S_INPUT, &t);
err = drv(file, VIDIOC_S_TUNER, &t);
if (err < 0)
dprintk("VIDIOCSTUNER / VIDIOC_S_INPUT: %ld\n", err);
dprintk("VIDIOCSTUNER / VIDIOC_S_TUNER: %ld\n", err);
return err;
}

Expand Down

0 comments on commit 9fc4d21

Please sign in to comment.