Skip to content

Commit

Permalink
[media] em28xx: adjust period size at runtime
Browse files Browse the repository at this point in the history
While the current hardcoded period is ok for the current values,
we may latter change the driver to work with different bit rates
or with different latencies than 64ms.

So, adust the period size at runtime.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
  • Loading branch information
Mauro Carvalho Chehab committed Jan 14, 2014
1 parent ebbfbc2 commit a02b9c2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions drivers/media/usb/em28xx/em28xx-audio.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,12 @@ static int snd_em28xx_capture_open(struct snd_pcm_substream *substream)
mutex_unlock(&dev->lock);
}

/* Dynamically adjust the period size */
snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_PERIOD_BYTES,
dev->adev.period * 95 / 100,
dev->adev.period * 105 / 100);

dev->adev.capture_pcm_substream = substream;

return 0;
Expand Down Expand Up @@ -803,6 +808,9 @@ static int em28xx_audio_urb_init(struct em28xx *dev)
em28xx_info("Number of URBs: %d, with %d packets and %d size",
num_urb, npackets, urb_size);

/* Estimate the bytes per period */
dev->adev.period = urb_size * npackets;

/* Allocate space to store the number of URBs to be used */

dev->adev.transfer_buffer = kcalloc(num_urb,
Expand Down
2 changes: 2 additions & 0 deletions drivers/media/usb/em28xx/em28xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,8 @@ struct em28xx_audio {
unsigned int hwptr_done_capture;
struct snd_card *sndcard;

size_t period;

int users;
spinlock_t slock;
};
Expand Down

0 comments on commit a02b9c2

Please sign in to comment.