Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 217688
b: refs/heads/master
c: 78cdb3e
h: refs/heads/master
v: v3
  • Loading branch information
Myron Stowe authored and Len Brown committed Oct 25, 2010
1 parent 0e2e35b commit a094a17
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d362edaf5386acedad4319a6721bb1540b74dcf7
refs/heads/master: 78cdb3ed4053798c894899b15d2255fb880edad4
23 changes: 11 additions & 12 deletions trunk/drivers/acpi/osl.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,27 +244,27 @@ acpi_physical_address __init acpi_os_get_root_pointer(void)
}
}

/* Must be called with 'acpi_ioremap_lock' lock held. */
/* Must be called with 'acpi_ioremap_lock' or RCU read lock held. */
static void __iomem *
acpi_map_vaddr_lookup(acpi_physical_address phys, acpi_size size)
{
struct acpi_ioremap *map;

list_for_each_entry(map, &acpi_ioremaps, list)
list_for_each_entry_rcu(map, &acpi_ioremaps, list)
if (map->phys <= phys &&
phys + size <= map->phys + map->size)
return map->virt + (phys - map->phys);

return NULL;
}

/* Must be called with 'acpi_ioremap_lock' lock held. */
/* Must be called with 'acpi_ioremap_lock' or RCU read lock held. */
static struct acpi_ioremap *
acpi_map_lookup_virt(void __iomem *virt, acpi_size size)
{
struct acpi_ioremap *map;

list_for_each_entry(map, &acpi_ioremaps, list)
list_for_each_entry_rcu(map, &acpi_ioremaps, list)
if (map->virt == virt && map->size == size)
return map;

Expand Down Expand Up @@ -302,7 +302,7 @@ acpi_os_map_memory(acpi_physical_address phys, acpi_size size)
map->size = size;

spin_lock_irqsave(&acpi_ioremap_lock, flags);
list_add_tail(&map->list, &acpi_ioremaps);
list_add_tail_rcu(&map->list, &acpi_ioremaps);
spin_unlock_irqrestore(&acpi_ioremap_lock, flags);

return virt;
Expand All @@ -328,9 +328,10 @@ void __ref acpi_os_unmap_memory(void __iomem *virt, acpi_size size)
return;
}

list_del(&map->list);
list_del_rcu(&map->list);
spin_unlock_irqrestore(&acpi_ioremap_lock, flags);

synchronize_rcu();
iounmap(map->virt);
kfree(map);
}
Expand Down Expand Up @@ -584,11 +585,10 @@ acpi_os_read_memory(acpi_physical_address phys_addr, u32 * value, u32 width)
u32 dummy;
void __iomem *virt_addr;
int size = width / 8, unmap = 0;
unsigned long flags;

spin_lock_irqsave(&acpi_ioremap_lock, flags);
rcu_read_lock();
virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
spin_unlock_irqrestore(&acpi_ioremap_lock, flags);
rcu_read_unlock();
if (!virt_addr) {
virt_addr = ioremap(phys_addr, size);
unmap = 1;
Expand Down Expand Up @@ -621,11 +621,10 @@ acpi_os_write_memory(acpi_physical_address phys_addr, u32 value, u32 width)
{
void __iomem *virt_addr;
int size = width / 8, unmap = 0;
unsigned long flags;

spin_lock_irqsave(&acpi_ioremap_lock, flags);
rcu_read_lock();
virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
spin_unlock_irqrestore(&acpi_ioremap_lock, flags);
rcu_read_unlock();
if (!virt_addr) {
virt_addr = ioremap(phys_addr, size);
unmap = 1;
Expand Down

0 comments on commit a094a17

Please sign in to comment.