Skip to content

Commit

Permalink
staging: et131x: Update TODO list
Browse files Browse the repository at this point in the history
Added some more tasks to the TODO list, as highlighted by Francois
Romieu <romieu@fr.zoreil.com>.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Mark Einon authored and Greg Kroah-Hartman committed Oct 11, 2011
1 parent a7203d5 commit a098582
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/staging/et131x/README
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.

Based on the driver found at https://sourceforge.net/projects/et131x/

Cleaned up immensely by Olaf Hartman and Christoph
Hellwig <hch@infradead.org>
Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org>

Note, the powermanagement options were removed from the vendor provided
driver as they did not build properly at the time.

TODO:
- Put the driver into a single file, with a .h for the registers layout.
- rx_ring.fbr{0, 1} can probably share a common structure
- Use of kmem_cache seems a bit unusual
- Use dma_alloc_... in place of pci_alloc_...
- It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
- PCI_VDEVICE ?

Please send patches to:
Greg Kroah-Hartman <gregkh@suse.de>
Expand Down

0 comments on commit a098582

Please sign in to comment.