Skip to content

Commit

Permalink
V4L/DVB (10753): siano: convert EXPORT_SYMBOL to EXPORT_SYMBOL_GPL
Browse files Browse the repository at this point in the history 
As pointed out by Mauro Chehab, we should always use EXPORT_SYMBOL_GPL
instead of EXPORT_SYMBOL wherever possible.

A message was posted to the linux-media mailing list about this, checking
with Uri Shkolnik of Siano Mobile Silicon if this is okay to convert.

As per Uri's response to this email, it is OK for us to make this conversion.

http://www.spinics.net/lists/linux-media/msg02200.html

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Michael Krufky authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 05860f2 commit a0beec8
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 21 deletions.
12 changes: 6 additions & 6 deletions drivers/media/dvb/siano/sms-cards.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ struct sms_board *sms_get_board(int id)

return &sms_boards[id];
}
EXPORT_SYMBOL(sms_get_board);
EXPORT_SYMBOL_GPL(sms_get_board);

static int sms_set_gpio(struct smscore_device_t *coredev, int pin, int enable)
{
Expand Down Expand Up @@ -139,7 +139,7 @@ int sms_board_setup(struct smscore_device_t *coredev)
}
return 0;
}
EXPORT_SYMBOL(sms_board_setup);
EXPORT_SYMBOL_GPL(sms_board_setup);

int sms_board_power(struct smscore_device_t *coredev, int onoff)
{
Expand All @@ -161,7 +161,7 @@ int sms_board_power(struct smscore_device_t *coredev, int onoff)
}
return 0;
}
EXPORT_SYMBOL(sms_board_power);
EXPORT_SYMBOL_GPL(sms_board_power);

int sms_board_led_feedback(struct smscore_device_t *coredev, int led)
{
Expand All @@ -184,7 +184,7 @@ int sms_board_led_feedback(struct smscore_device_t *coredev, int led)
}
return 0;
}
EXPORT_SYMBOL(sms_board_led_feedback);
EXPORT_SYMBOL_GPL(sms_board_led_feedback);

int sms_board_lna_control(struct smscore_device_t *coredev, int onoff)
{
Expand All @@ -203,7 +203,7 @@ int sms_board_lna_control(struct smscore_device_t *coredev, int onoff)
}
return -EINVAL;
}
EXPORT_SYMBOL(sms_board_lna_control);
EXPORT_SYMBOL_GPL(sms_board_lna_control);

int sms_board_load_modules(int id)
{
Expand All @@ -220,4 +220,4 @@ int sms_board_load_modules(int id)
}
return 0;
}
EXPORT_SYMBOL(sms_board_load_modules);
EXPORT_SYMBOL_GPL(sms_board_load_modules);
30 changes: 15 additions & 15 deletions drivers/media/dvb/siano/smscoreapi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@ int smscore_led_state(struct smscore_device_t *core, int led)
core->led_state = led;
return core->led_state;
}
EXPORT_SYMBOL(smscore_set_board_id);
EXPORT_SYMBOL_GPL(smscore_set_board_id);

int smscore_get_board_id(struct smscore_device_t *core)
{
return core->board_id;
}
EXPORT_SYMBOL(smscore_get_board_id);
EXPORT_SYMBOL_GPL(smscore_get_board_id);

struct smscore_registry_entry_t {
struct list_head entry;
Expand Down Expand Up @@ -172,7 +172,7 @@ int smscore_registry_getmode(char *devpath)

return default_mode;
}
EXPORT_SYMBOL(smscore_registry_getmode);
EXPORT_SYMBOL_GPL(smscore_registry_getmode);

static enum sms_device_type_st smscore_registry_gettype(char *devpath)
{
Expand Down Expand Up @@ -264,7 +264,7 @@ int smscore_register_hotplug(hotplug_t hotplug)

return rc;
}
EXPORT_SYMBOL(smscore_register_hotplug);
EXPORT_SYMBOL_GPL(smscore_register_hotplug);

/**
* unregister a client callback that called when device plugged in/unplugged
Expand Down Expand Up @@ -293,7 +293,7 @@ void smscore_unregister_hotplug(hotplug_t hotplug)

kmutex_unlock(&g_smscore_deviceslock);
}
EXPORT_SYMBOL(smscore_unregister_hotplug);
EXPORT_SYMBOL_GPL(smscore_unregister_hotplug);

static void smscore_notify_clients(struct smscore_device_t *coredev)
{
Expand Down Expand Up @@ -437,7 +437,7 @@ int smscore_register_device(struct smsdevice_params_t *params,

return 0;
}
EXPORT_SYMBOL(smscore_register_device);
EXPORT_SYMBOL_GPL(smscore_register_device);

/**
* sets initial device mode and notifies client hotplugs that device is ready
Expand Down Expand Up @@ -466,7 +466,7 @@ int smscore_start_device(struct smscore_device_t *coredev)

return rc;
}
EXPORT_SYMBOL(smscore_start_device);
EXPORT_SYMBOL_GPL(smscore_start_device);

static int smscore_sendrequest_and_wait(struct smscore_device_t *coredev,
void *buffer, size_t size,
Expand Down Expand Up @@ -695,7 +695,7 @@ void smscore_unregister_device(struct smscore_device_t *coredev)

sms_info("device %p destroyed", coredev);
}
EXPORT_SYMBOL(smscore_unregister_device);
EXPORT_SYMBOL_GPL(smscore_unregister_device);

static int smscore_detect_mode(struct smscore_device_t *coredev)
{
Expand Down Expand Up @@ -887,7 +887,7 @@ int smscore_get_device_mode(struct smscore_device_t *coredev)
{
return coredev->mode;
}
EXPORT_SYMBOL(smscore_get_device_mode);
EXPORT_SYMBOL_GPL(smscore_get_device_mode);

/**
* find client by response id & type within the clients list.
Expand Down Expand Up @@ -1015,7 +1015,7 @@ void smscore_onresponse(struct smscore_device_t *coredev,
smscore_putbuffer(coredev, cb);
}
}
EXPORT_SYMBOL(smscore_onresponse);
EXPORT_SYMBOL_GPL(smscore_onresponse);

/**
* return pointer to next free buffer descriptor from core pool
Expand All @@ -1041,7 +1041,7 @@ struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *coredev)

return cb;
}
EXPORT_SYMBOL(smscore_getbuffer);
EXPORT_SYMBOL_GPL(smscore_getbuffer);

/**
* return buffer descriptor to a pool
Expand All @@ -1056,7 +1056,7 @@ void smscore_putbuffer(struct smscore_device_t *coredev,
{
list_add_locked(&cb->entry, &coredev->buffers, &coredev->bufferslock);
}
EXPORT_SYMBOL(smscore_putbuffer);
EXPORT_SYMBOL_GPL(smscore_putbuffer);

static int smscore_validate_client(struct smscore_device_t *coredev,
struct smscore_client_t *client,
Expand Down Expand Up @@ -1136,7 +1136,7 @@ int smscore_register_client(struct smscore_device_t *coredev,

return 0;
}
EXPORT_SYMBOL(smscore_register_client);
EXPORT_SYMBOL_GPL(smscore_register_client);

/**
* frees smsclient object and all subclients associated with it
Expand Down Expand Up @@ -1167,7 +1167,7 @@ void smscore_unregister_client(struct smscore_client_t *client)

spin_unlock_irqrestore(&coredev->clientslock, flags);
}
EXPORT_SYMBOL(smscore_unregister_client);
EXPORT_SYMBOL_GPL(smscore_unregister_client);

/**
* verifies that source id is not taken by another client,
Expand Down Expand Up @@ -1207,7 +1207,7 @@ int smsclient_sendrequest(struct smscore_client_t *client,

return coredev->sendrequest_handler(coredev->context, buffer, size);
}
EXPORT_SYMBOL(smsclient_sendrequest);
EXPORT_SYMBOL_GPL(smsclient_sendrequest);


int smscore_configure_gpio(struct smscore_device_t *coredev, u32 pin,
Expand Down

0 comments on commit a0beec8

Please sign in to comment.