Skip to content

Commit

Permalink
[PATCH] cpufreq: acpi-cpufreq: Ignore failure from acpi_cpufreq_early…
Browse files Browse the repository at this point in the history
…_init_acpi

Ignore the return value of early_init_acpi(), as it can give false error
messages.  If there is something really wrong, then register_driver will
fail cleanly with EINVAL later.

[ background: modprobe acpi-cpufreq on systems not capable of speed-scaling
  started failing with 'invalid argument', where previously it would only
  ever -ENODEV

  I'm not 100% happy with the solution. It'd be better to handle
  failure properly, but this is a low-impact change for 2.6.18
  We can always revisit doing this better in .19   --davej.]

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Dave Jones authored and Linus Torvalds committed Aug 27, 2006
1 parent f8986c2 commit a0cc621
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -567,16 +567,11 @@ static struct cpufreq_driver acpi_cpufreq_driver = {
static int __init
acpi_cpufreq_init (void)
{
int result = 0;

dprintk("acpi_cpufreq_init\n");

result = acpi_cpufreq_early_init_acpi();
acpi_cpufreq_early_init_acpi();

if (!result)
result = cpufreq_register_driver(&acpi_cpufreq_driver);

return (result);
return cpufreq_register_driver(&acpi_cpufreq_driver);
}


Expand Down

0 comments on commit a0cc621

Please sign in to comment.