Skip to content

Commit

Permalink
V4L/DVB (11304): v4l2: remove v4l2_subdev_command calls where they ar…
Browse files Browse the repository at this point in the history
…e no longer needed.

Several i2c drivers still used v4l2_subdev_command, even though they were
converted to v4l2_subdev. Remove those unused .command callbacks.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 267ea2a commit a0d1251
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 56 deletions.
7 changes: 0 additions & 7 deletions drivers/media/video/cs5345.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,6 @@ static int cs5345_log_status(struct v4l2_subdev *sd)
return 0;
}

static int cs5345_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops cs5345_core_ops = {
Expand Down Expand Up @@ -214,8 +209,6 @@ MODULE_DEVICE_TABLE(i2c, cs5345_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "cs5345",
.driverid = I2C_DRIVERID_CS5345,
.command = cs5345_command,
.probe = cs5345_probe,
.remove = cs5345_remove,
.id_table = cs5345_id,
Expand Down
6 changes: 0 additions & 6 deletions drivers/media/video/m52790.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,6 @@ static int m52790_log_status(struct v4l2_subdev *sd)
return 0;
}

static int m52790_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops m52790_core_ops = {
Expand Down Expand Up @@ -210,7 +205,6 @@ MODULE_DEVICE_TABLE(i2c, m52790_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "m52790",
.command = m52790_command,
.probe = m52790_probe,
.remove = m52790_remove,
.id_table = m52790_id,
Expand Down
6 changes: 0 additions & 6 deletions drivers/media/video/ovcamchip/ovcamchip_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -322,11 +322,6 @@ static long ovcamchip_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg)
}
}

static int ovcamchip_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops ovcamchip_core_ops = {
Expand Down Expand Up @@ -394,7 +389,6 @@ MODULE_DEVICE_TABLE(i2c, ovcamchip_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "ovcamchip",
.command = ovcamchip_command,
.probe = ovcamchip_probe,
.remove = ovcamchip_remove,
.id_table = ovcamchip_id,
Expand Down
7 changes: 0 additions & 7 deletions drivers/media/video/saa717x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1380,11 +1380,6 @@ static int saa717x_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt)
return 0;
}

static int saa717x_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops saa717x_core_ops = {
Expand Down Expand Up @@ -1528,9 +1523,7 @@ MODULE_DEVICE_TABLE(i2c, saa717x_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "saa717x",
.command = saa717x_command,
.probe = saa717x_probe,
.remove = saa717x_remove,
.legacy_class = I2C_CLASS_TV_ANALOG | I2C_CLASS_TV_DIGITAL,
.id_table = saa717x_id,
};
6 changes: 0 additions & 6 deletions drivers/media/video/tlv320aic23b.c
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,6 @@ static int tlv320aic23b_log_status(struct v4l2_subdev *sd)
return 0;
}

static int tlv320aic23b_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops tlv320aic23b_core_ops = {
Expand Down Expand Up @@ -205,7 +200,6 @@ MODULE_DEVICE_TABLE(i2c, tlv320aic23b_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "tlv320aic23b",
.command = tlv320aic23b_command,
.probe = tlv320aic23b_probe,
.remove = tlv320aic23b_remove,
.id_table = tlv320aic23b_id,
Expand Down
6 changes: 0 additions & 6 deletions drivers/media/video/upd64031a.c
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,6 @@ static int upd64031a_s_register(struct v4l2_subdev *sd, struct v4l2_dbg_register
}
#endif

static int upd64031a_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops upd64031a_core_ops = {
Expand Down Expand Up @@ -267,7 +262,6 @@ MODULE_DEVICE_TABLE(i2c, upd64031a_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "upd64031a",
.command = upd64031a_command,
.probe = upd64031a_probe,
.remove = upd64031a_remove,
.id_table = upd64031a_id,
Expand Down
6 changes: 0 additions & 6 deletions drivers/media/video/upd64083.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,6 @@ static int upd64083_log_status(struct v4l2_subdev *sd)
return 0;
}

static int upd64083_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops upd64083_core_ops = {
Expand Down Expand Up @@ -239,7 +234,6 @@ MODULE_DEVICE_TABLE(i2c, upd64083_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "upd64083",
.command = upd64083_command,
.probe = upd64083_probe,
.remove = upd64083_remove,
.id_table = upd64083_id,
Expand Down
6 changes: 0 additions & 6 deletions drivers/media/video/vp27smpx.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,6 @@ static int vp27smpx_log_status(struct v4l2_subdev *sd)
return 0;
}

static int vp27smpx_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops vp27smpx_core_ops = {
Expand Down Expand Up @@ -206,7 +201,6 @@ MODULE_DEVICE_TABLE(i2c, vp27smpx_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "vp27smpx",
.command = vp27smpx_command,
.probe = vp27smpx_probe,
.remove = vp27smpx_remove,
.id_table = vp27smpx_id,
Expand Down
6 changes: 0 additions & 6 deletions drivers/media/video/wm8739.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,6 @@ static int wm8739_log_status(struct v4l2_subdev *sd)
return 0;
}

static int wm8739_command(struct i2c_client *client, unsigned cmd, void *arg)
{
return v4l2_subdev_command(i2c_get_clientdata(client), cmd, arg);
}

/* ----------------------------------------------------------------------- */

static const struct v4l2_subdev_core_ops wm8739_core_ops = {
Expand Down Expand Up @@ -343,7 +338,6 @@ MODULE_DEVICE_TABLE(i2c, wm8739_id);

static struct v4l2_i2c_driver_data v4l2_i2c_data = {
.name = "wm8739",
.command = wm8739_command,
.probe = wm8739_probe,
.remove = wm8739_remove,
.id_table = wm8739_id,
Expand Down

0 comments on commit a0d1251

Please sign in to comment.