Skip to content

Commit

Permalink
drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()
Browse files Browse the repository at this point in the history
In case of error, function arm_iommu_create_mapping() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
  • Loading branch information
Wei Yongjun authored and Inki Dae committed Dec 13, 2012
1 parent ddd8e95 commit a0e41b5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/exynos/exynos_drm_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ int drm_create_iommu_mapping(struct drm_device *drm_dev)
mapping = arm_iommu_create_mapping(&platform_bus_type, priv->da_start,
priv->da_space_size,
priv->da_space_order);
if (!mapping)
return -ENOMEM;
if (IS_ERR(mapping))
return PTR_ERR(mapping);

dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
GFP_KERNEL);
Expand Down

0 comments on commit a0e41b5

Please sign in to comment.