Skip to content

Commit

Permalink
drm/radeon: cope with foreign fences inside display
Browse files Browse the repository at this point in the history
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Maarten Lankhorst authored and Alex Deucher committed Oct 3, 2014
1 parent 38aea07 commit a0e8476
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 12 deletions.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/radeon/radeon.h
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ struct radeon_flip_work {
uint64_t base;
struct drm_pending_vblank_event *event;
struct radeon_bo *old_rbo;
struct radeon_fence *fence;
struct fence *fence;
};

struct r500_irq_stat_regs {
Expand Down
30 changes: 19 additions & 11 deletions drivers/gpu/drm/radeon/radeon_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -402,14 +402,21 @@ static void radeon_flip_work_func(struct work_struct *__work)

down_read(&rdev->exclusive_lock);
if (work->fence) {
r = radeon_fence_wait(work->fence, false);
if (r == -EDEADLK) {
up_read(&rdev->exclusive_lock);
do {
r = radeon_gpu_reset(rdev);
} while (r == -EAGAIN);
down_read(&rdev->exclusive_lock);
}
struct radeon_fence *fence;

fence = to_radeon_fence(work->fence);
if (fence && fence->rdev == rdev) {
r = radeon_fence_wait(fence, false);
if (r == -EDEADLK) {
up_read(&rdev->exclusive_lock);
do {
r = radeon_gpu_reset(rdev);
} while (r == -EAGAIN);
down_read(&rdev->exclusive_lock);
}
} else
r = fence_wait(work->fence, false);

if (r)
DRM_ERROR("failed to wait on page flip fence (%d)!\n", r);

Expand All @@ -418,7 +425,8 @@ static void radeon_flip_work_func(struct work_struct *__work)
* confused about which BO the CRTC is scanning out
*/

radeon_fence_unref(&work->fence);
fence_put(work->fence);
work->fence = NULL;
}

/* We borrow the event spin lock for protecting flip_status */
Expand Down Expand Up @@ -494,7 +502,7 @@ static int radeon_crtc_page_flip(struct drm_crtc *crtc,
DRM_ERROR("failed to pin new rbo buffer before flip\n");
goto cleanup;
}
work->fence = (struct radeon_fence *)fence_get(reservation_object_get_excl(new_rbo->tbo.resv));
work->fence = fence_get(reservation_object_get_excl(new_rbo->tbo.resv));
radeon_bo_get_tiling_flags(new_rbo, &tiling_flags, NULL);
radeon_bo_unreserve(new_rbo);

Expand Down Expand Up @@ -576,7 +584,7 @@ static int radeon_crtc_page_flip(struct drm_crtc *crtc,

cleanup:
drm_gem_object_unreference_unlocked(&work->old_rbo->gem_base);
radeon_fence_unref(&work->fence);
fence_put(work->fence);
kfree(work);
return r;
}
Expand Down

0 comments on commit a0e8476

Please sign in to comment.