Skip to content

Commit

Permalink
xfs: add const qualifiers to xfs error function args
Browse files Browse the repository at this point in the history
Change the tag and file name arguments to xfs_error_report() and
xfs_corruption_error() to use a const qualifier.

Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
  • Loading branch information
Alex Elder committed May 19, 2010
1 parent 74457cf commit a0e856b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 19 deletions.
30 changes: 15 additions & 15 deletions fs/xfs/xfs_error.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,34 +186,34 @@ xfs_cmn_err(int panic_tag, int level, xfs_mount_t *mp, char *fmt, ...)

void
xfs_error_report(
char *tag,
int level,
xfs_mount_t *mp,
char *fname,
int linenum,
inst_t *ra)
const char *tag,
int level,
struct xfs_mount *mp,
const char *filename,
int linenum,
inst_t *ra)
{
if (level <= xfs_error_level) {
xfs_cmn_err(XFS_PTAG_ERROR_REPORT,
CE_ALERT, mp,
"XFS internal error %s at line %d of file %s. Caller 0x%p\n",
tag, linenum, fname, ra);
tag, linenum, filename, ra);

xfs_stack_trace();
}
}

void
xfs_corruption_error(
char *tag,
int level,
xfs_mount_t *mp,
void *p,
char *fname,
int linenum,
inst_t *ra)
const char *tag,
int level,
struct xfs_mount *mp,
void *p,
const char *filename,
int linenum,
inst_t *ra)
{
if (level <= xfs_error_level)
xfs_hex_dump(p, 16);
xfs_error_report(tag, level, mp, fname, linenum, ra);
xfs_error_report(tag, level, mp, filename, linenum, ra);
}
9 changes: 5 additions & 4 deletions fs/xfs/xfs_error.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ extern int xfs_error_trap(int);

struct xfs_mount;

extern void xfs_error_report(char *tag, int level, struct xfs_mount *mp,
char *fname, int linenum, inst_t *ra);
extern void xfs_corruption_error(char *tag, int level, struct xfs_mount *mp,
void *p, char *fname, int linenum, inst_t *ra);
extern void xfs_error_report(const char *tag, int level, struct xfs_mount *mp,
const char *filename, int linenum, inst_t *ra);
extern void xfs_corruption_error(const char *tag, int level,
struct xfs_mount *mp, void *p, const char *filename,
int linenum, inst_t *ra);

#define XFS_ERROR_REPORT(e, lvl, mp) \
xfs_error_report(e, lvl, mp, __FILE__, __LINE__, __return_address)
Expand Down

0 comments on commit a0e856b

Please sign in to comment.