Skip to content

Commit

Permalink
sched: convert rebalance_domains() to cpumask_var_t.
Browse files Browse the repository at this point in the history
Impact: stack usage reduction

Dynamically allocating cpumasks (when CONFIG_CPUMASK_OFFSTACK) saves
space in the stack.  cpumask_var_t is just a struct cpumask for
!CONFIG_CPUMASK_OFFSTACK.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Rusty Russell authored and Ingo Molnar committed Nov 24, 2008
1 parent 4d2732c commit a0e9024
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -3850,7 +3850,11 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle)
unsigned long next_balance = jiffies + 60*HZ;
int update_next_balance = 0;
int need_serialize;
cpumask_t tmp;
cpumask_var_t tmp;

/* Fails alloc? Rebalancing probably not a priority right now. */
if (!alloc_cpumask_var(&tmp, GFP_ATOMIC))
return;

for_each_domain(cpu, sd) {
if (!(sd->flags & SD_LOAD_BALANCE))
Expand All @@ -3875,7 +3879,7 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle)
}

if (time_after_eq(jiffies, sd->last_balance + interval)) {
if (load_balance(cpu, rq, sd, idle, &balance, &tmp)) {
if (load_balance(cpu, rq, sd, idle, &balance, tmp)) {
/*
* We've pulled tasks over so either we're no
* longer idle, or one of our SMT siblings is
Expand Down Expand Up @@ -3909,6 +3913,8 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle)
*/
if (likely(update_next_balance))
rq->next_balance = next_balance;

free_cpumask_var(tmp);
}

/*
Expand Down

0 comments on commit a0e9024

Please sign in to comment.