Skip to content

Commit

Permalink
staging: unisys: use local variable
Browse files Browse the repository at this point in the history
we are getting dev_t as an argument in the function, so use the local
variable instead of the global variable "majordev".
this global variable will be removed in one of the next patch of the
series.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sudip Mukherjee authored and Greg Kroah-Hartman committed Mar 26, 2015
1 parent 61986f7 commit a119114
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/staging/unisys/visorchipset/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,16 @@ visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
majordev = major_dev;
cdev_init(&file_cdev, &visorchipset_fops);
file_cdev.owner = THIS_MODULE;
if (MAJOR(majordev) == 0) {
if (MAJOR(major_dev) == 0) {
/* dynamic major device number registration required */
if (alloc_chrdev_region(&majordev, 0, 1, MYDRVNAME) < 0)
if (alloc_chrdev_region(&major_dev, 0, 1, MYDRVNAME) < 0)
return -1;
} else {
/* static major device number registration required */
if (register_chrdev_region(majordev, 1, MYDRVNAME) < 0)
if (register_chrdev_region(major_dev, 1, MYDRVNAME) < 0)
return -1;
}
rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1);
if (rc < 0)
return -1;
return 0;
Expand Down

0 comments on commit a119114

Please sign in to comment.