Skip to content

Commit

Permalink
ARM: SoC: convert Tegra to SMP operations
Browse files Browse the repository at this point in the history
Convert Tegra to use struct smp_operations to provide its SMP
and CPU hotplug operations.

Tested on Harmony.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Olof Johansson <olof@lixom.net>
Acked-by: Nicolas Pitre <nico@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
  • Loading branch information
Marc Zyngier authored and Arnd Bergmann committed Sep 13, 2012
1 parent 0691532 commit a172573
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 19 deletions.
2 changes: 2 additions & 0 deletions arch/arm/mach-tegra/board-dt-tegra20.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
#include "board-harmony.h"
#include "clock.h"
#include "devices.h"
#include "common.h"

struct of_dev_auxdata tegra20_auxdata_lookup[] __initdata = {
OF_DEV_AUXDATA("nvidia,tegra20-sdhci", TEGRA_SDMMC1_BASE, "sdhci-tegra.0", NULL),
Expand Down Expand Up @@ -166,6 +167,7 @@ static const char *tegra20_dt_board_compat[] = {

DT_MACHINE_START(TEGRA_DT, "nVidia Tegra20 (Flattened Device Tree)")
.map_io = tegra_map_common_io,
.smp = smp_ops(tegra_smp_ops),
.init_early = tegra20_init_early,
.init_irq = tegra_dt_init_irq,
.handle_irq = gic_handle_irq,
Expand Down
2 changes: 2 additions & 0 deletions arch/arm/mach-tegra/board-dt-tegra30.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@

#include "board.h"
#include "clock.h"
#include "common.h"

struct of_dev_auxdata tegra30_auxdata_lookup[] __initdata = {
OF_DEV_AUXDATA("nvidia,tegra20-sdhci", 0x78000000, "sdhci-tegra.0", NULL),
Expand Down Expand Up @@ -83,6 +84,7 @@ static const char *tegra30_dt_board_compat[] = {
};

DT_MACHINE_START(TEGRA30_DT, "NVIDIA Tegra30 (Flattened Device Tree)")
.smp = smp_ops(tegra_smp_ops),
.map_io = tegra_map_common_io,
.init_early = tegra30_init_early,
.init_irq = tegra_dt_init_irq,
Expand Down
2 changes: 2 additions & 0 deletions arch/arm/mach-tegra/board-harmony.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
#include "clock.h"
#include "devices.h"
#include "gpio-names.h"
#include "common.h"

static struct plat_serial8250_port debug_uart_platform_data[] = {
{
Expand Down Expand Up @@ -185,6 +186,7 @@ static void __init tegra_harmony_init(void)

MACHINE_START(HARMONY, "harmony")
.atag_offset = 0x100,
.smp = smp_ops(tegra_smp_ops),
.fixup = tegra_harmony_fixup,
.map_io = tegra_map_common_io,
.init_early = tegra20_init_early,
Expand Down
2 changes: 2 additions & 0 deletions arch/arm/mach-tegra/board-paz00.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
#include "clock.h"
#include "devices.h"
#include "gpio-names.h"
#include "common.h"

static struct plat_serial8250_port debug_uart_platform_data[] = {
{
Expand Down Expand Up @@ -223,6 +224,7 @@ static void __init tegra_paz00_init(void)

MACHINE_START(PAZ00, "Toshiba AC100 / Dynabook AZ")
.atag_offset = 0x100,
.smp = smp_ops(tegra_smp_ops),
.fixup = tegra_paz00_fixup,
.map_io = tegra_map_common_io,
.init_early = tegra20_init_early,
Expand Down
2 changes: 2 additions & 0 deletions arch/arm/mach-tegra/board-trimslice.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include "clock.h"
#include "devices.h"
#include "gpio-names.h"
#include "common.h"

#include "board-trimslice.h"

Expand Down Expand Up @@ -171,6 +172,7 @@ static void __init tegra_trimslice_init(void)

MACHINE_START(TRIMSLICE, "trimslice")
.atag_offset = 0x100,
.smp = smp_ops(tegra_smp_ops),
.fixup = tegra_trimslice_fixup,
.map_io = tegra_map_common_io,
.init_early = tegra20_init_early,
Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-tegra/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

#include "board.h"
#include "clock.h"
#include "common.h"
#include "fuse.h"
#include "pmc.h"
#include "apbio.h"
Expand Down
3 changes: 3 additions & 0 deletions arch/arm/mach-tegra/common.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
extern struct smp_operations tegra_smp_ops;

extern void tegra_cpu_die(unsigned int cpu);
16 changes: 1 addition & 15 deletions arch/arm/mach-tegra/hotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,17 +87,12 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
}
}

int platform_cpu_kill(unsigned int cpu)
{
return 1;
}

/*
* platform-specific code to shutdown a CPU
*
* Called with IRQs disabled
*/
void platform_cpu_die(unsigned int cpu)
void __ref tegra_cpu_die(unsigned int cpu)
{
int spurious = 0;

Expand All @@ -116,12 +111,3 @@ void platform_cpu_die(unsigned int cpu)
if (spurious)
pr_warn("CPU%u: %u spurious wakeup calls\n", cpu, spurious);
}

int platform_cpu_disable(unsigned int cpu)
{
/*
* we don't allow CPU 0 to be shutdown (it is still too special
* e.g. clock tick interrupts)
*/
return cpu == 0 ? -EPERM : 0;
}
20 changes: 16 additions & 4 deletions arch/arm/mach-tegra/platsmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
#include "flowctrl.h"
#include "reset.h"

#include "common.h"

extern void tegra_secondary_startup(void);

static void __iomem *scu_base = IO_ADDRESS(TEGRA_ARM_PERIF_BASE);
Expand All @@ -50,7 +52,7 @@ static void __iomem *scu_base = IO_ADDRESS(TEGRA_ARM_PERIF_BASE);
#define CPU_CLOCK(cpu) (0x1<<(8+cpu))
#define CPU_RESET(cpu) (0x1111ul<<(cpu))

void __cpuinit platform_secondary_init(unsigned int cpu)
static void __cpuinit tegra_secondary_init(unsigned int cpu)
{
/*
* if any interrupts are already enabled for the primary
Expand Down Expand Up @@ -117,7 +119,7 @@ static int tegra30_power_up_cpu(unsigned int cpu)
return 0;
}

int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)
static int __cpuinit tegra_boot_secondary(unsigned int cpu, struct task_struct *idle)
{
int status;

Expand Down Expand Up @@ -165,7 +167,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)
* Initialise the CPU possible map early - this describes the CPUs
* which may be present or become present in the system.
*/
void __init smp_init_cpus(void)
static void __init tegra_smp_init_cpus(void)
{
unsigned int i, ncores = scu_get_core_count(scu_base);

Expand All @@ -181,8 +183,18 @@ void __init smp_init_cpus(void)
set_smp_cross_call(gic_raise_softirq);
}

void __init platform_smp_prepare_cpus(unsigned int max_cpus)
static void __init tegra_smp_prepare_cpus(unsigned int max_cpus)
{
tegra_cpu_reset_handler_init();
scu_enable(scu_base);
}

struct smp_operations tegra_smp_ops __initdata = {
.smp_init_cpus = tegra_smp_init_cpus,
.smp_prepare_cpus = tegra_smp_prepare_cpus,
.smp_secondary_init = tegra_secondary_init,
.smp_boot_secondary = tegra_boot_secondary,
#ifdef CONFIG_HOTPLUG_CPU
.cpu_die = tegra_cpu_die,
#endif
};

0 comments on commit a172573

Please sign in to comment.