Skip to content

Commit

Permalink
NFS: Clean up nfs_create_request comments
Browse files Browse the repository at this point in the history
Remove some stale comments about hard limits which went away in 2.5.

Signed-off-by: Jason Uhlenkott <juhlenko@akamai.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Jason Uhlenkott authored and Trond Myklebust committed May 2, 2007
1 parent 61322b3 commit a19b89c
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions fs/nfs/pagelist.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,7 @@ nfs_page_free(struct nfs_page *p)
* @count: number of bytes to read/write
*
* The page must be locked by the caller. This makes sure we never
* create two different requests for the same page, and avoids
* a possible deadlock when we reach the hard limit on the number
* of dirty pages.
* create two different requests for the same page.
* User should ensure it is safe to sleep in this function.
*/
struct nfs_page *
Expand All @@ -64,16 +62,12 @@ nfs_create_request(struct nfs_open_context *ctx, struct inode *inode,
struct nfs_server *server = NFS_SERVER(inode);
struct nfs_page *req;

/* Deal with hard limits. */
for (;;) {
/* try to allocate the request struct */
req = nfs_page_alloc();
if (req != NULL)
break;

/* Try to free up at least one request in order to stay
* below the hard limit
*/
if (signalled() && (server->flags & NFS_MOUNT_INTR))
return ERR_PTR(-ERESTARTSYS);
yield();
Expand Down

0 comments on commit a19b89c

Please sign in to comment.