Skip to content

Commit

Permalink
x86, MM: virtual address debug, v2
Browse files Browse the repository at this point in the history
I've removed the test from phys_to_nid and made a function from __phys_addr
only when the debugging is enabled (on x86_32).

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: tglx@linutronix.de
Cc: hpa@zytor.com
Cc: Mike Travis <travis@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: <x86@kernel.org>
Cc: linux-mm@kvack.org
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Jiri Slaby authored and Ingo Molnar committed Jun 19, 2008
1 parent 59ea746 commit a1bf963
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions arch/x86/mm/ioremap.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ static inline int phys_addr_valid(unsigned long addr)
return 1;
}

#ifdef CONFIG_DEBUG_VIRTUAL
unsigned long __phys_addr(unsigned long x)
{
/* VMALLOC_* aren't constants; not available at the boot time */
Expand All @@ -59,6 +60,7 @@ unsigned long __phys_addr(unsigned long x)
return x - PAGE_OFFSET;
}
EXPORT_SYMBOL(__phys_addr);
#endif

#endif

Expand Down
1 change: 0 additions & 1 deletion include/asm-x86/mmzone_64.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ static inline __attribute__((pure)) int phys_to_nid(unsigned long addr)
{
unsigned nid;
VIRTUAL_BUG_ON(!memnodemap);
VIRTUAL_BUG_ON((addr >> memnode_shift) >= memnodemapsize);
nid = memnodemap[addr >> memnode_shift];
VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]);
return nid;
Expand Down
4 changes: 4 additions & 0 deletions include/asm-x86/page_32.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ typedef struct page *pgtable_t;

#ifndef __ASSEMBLY__
#define __phys_addr_const(x) ((x) - PAGE_OFFSET)
#ifdef CONFIG_DEBUG_VIRTUAL
extern unsigned long __phys_addr(unsigned long);
#else
#define __phys_addr(x) ((x) - PAGE_OFFSET)
#endif
#define __phys_reloc_hide(x) RELOC_HIDE((x), 0)

#ifdef CONFIG_FLATMEM
Expand Down

0 comments on commit a1bf963

Please sign in to comment.