Skip to content

Commit

Permalink
ocfs2: __ocfs2_mark_extent_written() doesn't need struct inode.
Browse files Browse the repository at this point in the history
We only allow unwritten extents on data, so the toplevel
ocfs2_mark_extent_written() can use an inode all it wants.  But the
subfunction isn't even using the inode argument.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
  • Loading branch information
Joel Becker committed Sep 4, 2009
1 parent f3868d0 commit a1cf076
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions fs/ocfs2/alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -5026,9 +5026,8 @@ static int ocfs2_replace_extent_rec(handle_t *handle,
* have been brought into cache (and pinned via the journal), so the
* extra overhead is not expressed in terms of disk reads.
*/
static int __ocfs2_mark_extent_written(struct inode *inode,
static int __ocfs2_mark_extent_written(handle_t *handle,
struct ocfs2_extent_tree *et,
handle_t *handle,
struct ocfs2_path *path,
int split_index,
struct ocfs2_extent_rec *split_rec,
Expand Down Expand Up @@ -5062,7 +5061,7 @@ static int __ocfs2_mark_extent_written(struct inode *inode,

/*
* The core merge / split code wants to know how much room is
* left in this inodes allocation tree, so we pass the
* left in this allocation tree, so we pass the
* rightmost extent list.
*/
if (path->p_tree_depth) {
Expand Down Expand Up @@ -5185,7 +5184,7 @@ int ocfs2_mark_extent_written(struct inode *inode,
split_rec.e_flags = path_leaf_el(left_path)->l_recs[index].e_flags;
split_rec.e_flags &= ~OCFS2_EXT_UNWRITTEN;

ret = __ocfs2_mark_extent_written(inode, et, handle, left_path,
ret = __ocfs2_mark_extent_written(handle, et, left_path,
index, &split_rec, meta_ac,
dealloc);
if (ret)
Expand Down

0 comments on commit a1cf076

Please sign in to comment.