Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 256835
b: refs/heads/master
c: 3759a0d
h: refs/heads/master
i:
  256833: 4500209
  256831: 7867b8a
v: v3
  • Loading branch information
Tejun Heo authored and Oleg Nesterov committed Jun 4, 2011
1 parent efe9d76 commit a1e0ce8
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 81be24b8cdeb69e62f9d1b6b425fd9ffdd37f581
refs/heads/master: 3759a0d94c18764247b66511d1038f2b93aa95de
2 changes: 1 addition & 1 deletion trunk/fs/exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1772,7 +1772,7 @@ static int zap_process(struct task_struct *start, int exit_code)

t = start;
do {
task_clear_jobctl_stop_pending(t);
task_clear_jobctl_pending(t, JOBCTL_STOP_PENDING);
if (t != current && t->mm) {
sigaddset(&t->pending.signal, SIGKILL);
signal_wake_up(t, 1);
Expand Down
5 changes: 4 additions & 1 deletion trunk/include/linux/sched.h
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,10 @@ extern void thread_group_times(struct task_struct *p, cputime_t *ut, cputime_t *
#define JOBCTL_STOP_CONSUME (1 << JOBCTL_STOP_CONSUME_BIT)
#define JOBCTL_TRAPPING (1 << JOBCTL_TRAPPING_BIT)

extern void task_clear_jobctl_stop_pending(struct task_struct *task);
#define JOBCTL_PENDING_MASK JOBCTL_STOP_PENDING

extern void task_clear_jobctl_pending(struct task_struct *task,
unsigned int mask);

#ifdef CONFIG_PREEMPT_RCU

Expand Down
27 changes: 17 additions & 10 deletions trunk/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static inline int has_pending_signals(sigset_t *signal, sigset_t *blocked)

static int recalc_sigpending_tsk(struct task_struct *t)
{
if ((t->jobctl & JOBCTL_STOP_PENDING) ||
if ((t->jobctl & JOBCTL_PENDING_MASK) ||
PENDING(&t->pending, &t->blocked) ||
PENDING(&t->signal->shared_pending, &t->blocked)) {
set_tsk_thread_flag(t, TIF_SIGPENDING);
Expand Down Expand Up @@ -245,18 +245,25 @@ static void task_clear_jobctl_trapping(struct task_struct *task)
}

/**
* task_clear_jobctl_stop_pending - clear pending group stop
* task_clear_jobctl_pending - clear jobctl pending bits
* @task: target task
* @mask: pending bits to clear
*
* Clear group stop states for @task.
* Clear @mask from @task->jobctl. @mask must be subset of
* %JOBCTL_PENDING_MASK. If %JOBCTL_STOP_PENDING is being cleared, other
* STOP bits are cleared together.
*
* CONTEXT:
* Must be called with @task->sighand->siglock held.
*/
void task_clear_jobctl_stop_pending(struct task_struct *task)
void task_clear_jobctl_pending(struct task_struct *task, unsigned int mask)
{
task->jobctl &= ~(JOBCTL_STOP_PENDING | JOBCTL_STOP_CONSUME |
JOBCTL_STOP_DEQUEUED);
BUG_ON(mask & ~JOBCTL_PENDING_MASK);

if (mask & JOBCTL_STOP_PENDING)
mask |= JOBCTL_STOP_CONSUME | JOBCTL_STOP_DEQUEUED;

task->jobctl &= ~mask;
}

/**
Expand All @@ -282,7 +289,7 @@ static bool task_participate_group_stop(struct task_struct *task)

WARN_ON_ONCE(!(task->jobctl & JOBCTL_STOP_PENDING));

task_clear_jobctl_stop_pending(task);
task_clear_jobctl_pending(task, JOBCTL_STOP_PENDING);

if (!consume)
return false;
Expand Down Expand Up @@ -810,7 +817,7 @@ static int prepare_signal(int sig, struct task_struct *p, int from_ancestor_ns)
rm_from_queue(SIG_KERNEL_STOP_MASK, &signal->shared_pending);
t = p;
do {
task_clear_jobctl_stop_pending(t);
task_clear_jobctl_pending(t, JOBCTL_STOP_PENDING);
rm_from_queue(SIG_KERNEL_STOP_MASK, &t->pending);
wake_up_state(t, __TASK_STOPPED);
} while_each_thread(p, t);
Expand Down Expand Up @@ -926,7 +933,7 @@ static void complete_signal(int sig, struct task_struct *p, int group)
signal->group_stop_count = 0;
t = p;
do {
task_clear_jobctl_stop_pending(t);
task_clear_jobctl_pending(t, JOBCTL_STOP_PENDING);
sigaddset(&t->pending.signal, SIGKILL);
signal_wake_up(t, 1);
} while_each_thread(p, t);
Expand Down Expand Up @@ -1161,7 +1168,7 @@ int zap_other_threads(struct task_struct *p)
p->signal->group_stop_count = 0;

while_each_thread(p, t) {
task_clear_jobctl_stop_pending(t);
task_clear_jobctl_pending(t, JOBCTL_STOP_PENDING);
count++;

/* Don't bother with already dead threads */
Expand Down

0 comments on commit a1e0ce8

Please sign in to comment.