Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 275112
b: refs/heads/master
c: a3fbbde
h: refs/heads/master
v: v3
  • Loading branch information
Al Viro authored and Linus Torvalds committed Nov 7, 2011
1 parent 969ac2c commit a1e3eb2
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 54a0f91301950af3d6ae2ff2bf710c9c68a9bfea
refs/heads/master: a3fbbde70a0cec017f2431e8f8de208708c76acc
16 changes: 15 additions & 1 deletion trunk/fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ static int follow_managed(struct path *path, unsigned flags)
mntput(path->mnt);
if (ret == -EISDIR)
ret = 0;
return ret;
return ret < 0 ? ret : need_mntput;
}

int follow_down_one(struct path *path)
Expand Down Expand Up @@ -900,6 +900,7 @@ static bool __follow_mount_rcu(struct nameidata *nd, struct path *path,
break;
path->mnt = mounted;
path->dentry = mounted->mnt_root;
nd->flags |= LOOKUP_JUMPED;
nd->seq = read_seqcount_begin(&path->dentry->d_seq);
/*
* Update the inode too. We don't need to re-check the
Expand Down Expand Up @@ -1213,6 +1214,8 @@ static int do_lookup(struct nameidata *nd, struct qstr *name,
path_put_conditional(path, nd);
return err;
}
if (err)
nd->flags |= LOOKUP_JUMPED;
*inode = path->dentry->d_inode;
return 0;
}
Expand Down Expand Up @@ -2146,6 +2149,10 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
}

/* create side of things */
/*
* This will *only* deal with leaving RCU mode - LOOKUP_JUMPED has been
* cleared when we got to the last component we are about to look up
*/
error = complete_walk(nd);
if (error)
return ERR_PTR(error);
Expand Down Expand Up @@ -2214,6 +2221,9 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
if (error < 0)
goto exit_dput;

if (error)
nd->flags |= LOOKUP_JUMPED;

error = -ENOENT;
if (!path->dentry->d_inode)
goto exit_dput;
Expand All @@ -2223,6 +2233,10 @@ static struct file *do_last(struct nameidata *nd, struct path *path,

path_to_nameidata(path, nd);
nd->inode = path->dentry->d_inode;
/* Why this, you ask? _Now_ we might have grown LOOKUP_JUMPED... */
error = complete_walk(nd);
if (error)
goto exit;
error = -EISDIR;
if (S_ISDIR(nd->inode->i_mode))
goto exit;
Expand Down

0 comments on commit a1e3eb2

Please sign in to comment.