Skip to content

Commit

Permalink
bnx2: fix skb truesize underestimation
Browse files Browse the repository at this point in the history
bnx2 allocates a full page per fragment. We must account PAGE_SIZE
increments on skb->truesize, not the actual frag length.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Oct 13, 2011
1 parent bdb28a9 commit a1f4e8b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/broadcom/bnx2.c
Original file line number Diff line number Diff line change
Expand Up @@ -3051,7 +3051,6 @@ bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, struct sk_buff *skb,
&skb_shinfo(skb)->frags[i - 1];
frag->size -= tail;
skb->data_len -= tail;
skb->truesize -= tail;
}
return 0;
}
Expand Down Expand Up @@ -3083,7 +3082,7 @@ bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, struct sk_buff *skb,

frag_size -= frag_len;
skb->data_len += frag_len;
skb->truesize += frag_len;
skb->truesize += PAGE_SIZE;
skb->len += frag_len;

pg_prod = NEXT_RX_BD(pg_prod);
Expand Down

0 comments on commit a1f4e8b

Please sign in to comment.