Skip to content

Commit

Permalink
Input: fix potential overflows in driver/input/touchscreen
Browse files Browse the repository at this point in the history
Change all sprintfs into snprintfs to make sure we won't stomp on
data adjacent to our buffers.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Dmitry Torokhov committed Jun 26, 2006
1 parent 10ca4c0 commit a21466c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/input/touchscreen/gunze.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ static int gunze_connect(struct serio *serio, struct serio_driver *drv)

gunze->serio = serio;
gunze->dev = input_dev;
sprintf(gunze->phys, "%s/input0", serio->phys);
snprintf(gunze->phys, sizeof(serio->phys), "%s/input0", serio->phys);

input_dev->private = gunze;
input_dev->name = "Gunze AHL-51S TouchScreen";
Expand Down
2 changes: 1 addition & 1 deletion drivers/input/touchscreen/h3600_ts_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ static int h3600ts_connect(struct serio *serio, struct serio_driver *drv)

ts->serio = serio;
ts->dev = input_dev;
sprintf(ts->phys, "%s/input0", serio->phys);
snprintf(ts->phys, sizeof(ts->phys), "%s/input0", serio->phys);

input_dev->name = "H3600 TouchScreen";
input_dev->phys = ts->phys;
Expand Down
2 changes: 1 addition & 1 deletion drivers/input/touchscreen/mtouch.c
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ static int mtouch_connect(struct serio *serio, struct serio_driver *drv)

mtouch->serio = serio;
mtouch->dev = input_dev;
sprintf(mtouch->phys, "%s/input0", serio->phys);
snprintf(mtouch->phys, sizeof(mtouch->phys), "%s/input0", serio->phys);

input_dev->private = mtouch;
input_dev->name = "MicroTouch Serial TouchScreen";
Expand Down

0 comments on commit a21466c

Please sign in to comment.