Skip to content

Commit

Permalink
gianfar: Remove unused gfar_add_fcb() function parameter
Browse files Browse the repository at this point in the history
- Also, use cacheable_memzero instead of memset for performance reasons.

Signed-off-by: Dai Haruki <dai.haruki@freescale.com>
Acked-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dai Haruki authored and David S. Miller committed Dec 16, 2008
1 parent 2c2db48 commit a22823e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/gianfar.c
Original file line number Diff line number Diff line change
Expand Up @@ -1166,11 +1166,11 @@ static int gfar_enet_open(struct net_device *dev)
return err;
}

static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb, struct txbd8 *bdp)
static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb)
{
struct txfcb *fcb = (struct txfcb *)skb_push (skb, GMAC_FCB_LEN);

memset(fcb, 0, GMAC_FCB_LEN);
cacheable_memzero(fcb, GMAC_FCB_LEN);

return fcb;
}
Expand Down Expand Up @@ -1233,14 +1233,14 @@ static int gfar_start_xmit(struct sk_buff *skb, struct net_device *dev)

/* Set up checksumming */
if (CHECKSUM_PARTIAL == skb->ip_summed) {
fcb = gfar_add_fcb(skb, txbdp);
fcb = gfar_add_fcb(skb);
status |= TXBD_TOE;
gfar_tx_checksum(skb, fcb);
}

if (priv->vlgrp && vlan_tx_tag_present(skb)) {
if (unlikely(NULL == fcb)) {
fcb = gfar_add_fcb(skb, txbdp);
fcb = gfar_add_fcb(skb);
status |= TXBD_TOE;
}

Expand Down

0 comments on commit a22823e

Please sign in to comment.