Skip to content

Commit

Permalink
[media] gspca - ov519: Simplify the LED control functions
Browse files Browse the repository at this point in the history 
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jean-François Moine authored and Mauro Carvalho Chehab committed Dec 29, 2010
1 parent e281702 commit a23acec
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/media/video/gspca/ov519.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2639,14 +2639,14 @@ static void ov51x_led_control(struct sd *sd, int on)
switch (sd->bridge) {
/* OV511 has no LED control */
case BRIDGE_OV511PLUS:
reg_w(sd, R511_SYS_LED_CTL, on ? 1 : 0);
reg_w(sd, R511_SYS_LED_CTL, on);
break;
case BRIDGE_OV518:
case BRIDGE_OV518PLUS:
reg_w_mask(sd, R518_GPIO_OUT, on ? 0x02 : 0x00, 0x02);
reg_w_mask(sd, R518_GPIO_OUT, 0x02 * on, 0x02);
break;
case BRIDGE_OV519:
reg_w_mask(sd, OV519_GPIO_DATA_OUT0, !on, 1); /* 0 / 1 */
reg_w_mask(sd, OV519_GPIO_DATA_OUT0, on, 1);
break;
}
}
Expand Down Expand Up @@ -2938,7 +2938,7 @@ static int sd_config(struct gspca_dev *gspca_dev,
struct cam *cam = &gspca_dev->cam;

sd->bridge = id->driver_info & BRIDGE_MASK;
sd->invert_led = id->driver_info & BRIDGE_INVERT_LED;
sd->invert_led = (id->driver_info & BRIDGE_INVERT_LED) != 0;

switch (sd->bridge) {
case BRIDGE_OV511:
Expand Down

0 comments on commit a23acec

Please sign in to comment.