Skip to content

Commit

Permalink
[PATCH] pcnet32: remove incorrect pcnet32_free_ring
Browse files Browse the repository at this point in the history
During a code scan for another change I discovered that this call to
pcnet32_free_ring must be removed.  If the open fails due to a lack of
memory all the ring structures are removed via the call to free_ring
and a subsequent call to open will dereference a null pointer in
pcnet32_init_ring.

Please apply to 2.6.17.

Signed-off-by:  Don Fry <brazilnut@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Don Fry authored and Jeff Garzik committed May 27, 2006
1 parent 80871e6 commit a24b163
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/pcnet32.c
Original file line number Diff line number Diff line change
Expand Up @@ -1774,8 +1774,6 @@ static int pcnet32_open(struct net_device *dev)
lp->rx_dma_addr[i] = 0;
}

pcnet32_free_ring(dev);

/*
* Switch back to 16bit mode to avoid problems with dumb
* DOS packet driver after a warm reboot
Expand Down

0 comments on commit a24b163

Please sign in to comment.