Skip to content

Commit

Permalink
x86: cleanup setup_node_zones called by paging_init()
Browse files Browse the repository at this point in the history
setup_node_zones() calcuates some variables but only use them when
FLAT_NODE_MEM_MAP is set

so change the MACRO postion to avoid calculating.

also change it to static, and rename it to flat_setup_node_zones().

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Yinghai Lu authored and Ingo Molnar committed Jan 30, 2008
1 parent 94878ef commit a261670
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions arch/x86/mm/numa_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,9 @@ void __init setup_node_bootmem(int nodeid, unsigned long start,
node_set_online(nodeid);
}

#ifdef CONFIG_FLAT_NODE_MEM_MAP
/* Initialize final allocator for a zone */
void __init setup_node_zones(int nodeid)
static void __init flat_setup_node_zones(int nodeid)
{
unsigned long start_pfn, end_pfn, memmapsize, limit;

Expand All @@ -250,14 +251,16 @@ void __init setup_node_zones(int nodeid)
*/
memmapsize = sizeof(struct page) * (end_pfn-start_pfn);
limit = end_pfn << PAGE_SHIFT;
#ifdef CONFIG_FLAT_NODE_MEM_MAP

NODE_DATA(nodeid)->node_mem_map =
__alloc_bootmem_core(NODE_DATA(nodeid)->bdata,
memmapsize, SMP_CACHE_BYTES,
round_down(limit - memmapsize, PAGE_SIZE),
limit);
#endif
}
#else
#define flat_setup_node_zones(i) do {} while (0)
#endif

/*
* There are unfortunately some poorly designed mainboards around that
Expand Down Expand Up @@ -581,7 +584,7 @@ void __init paging_init(void)
sparse_init();

for_each_online_node(i)
setup_node_zones(i);
flat_setup_node_zones(i);

free_area_init_nodes(max_zone_pfns);
}
Expand Down

0 comments on commit a261670

Please sign in to comment.