Skip to content

Commit

Permalink
MMC: at91 mmc linkage updates
Browse files Browse the repository at this point in the history
Linker level tweaks for the AT91 MMC driver:

  - fix a wrongly-exported symbol
  - move probe() to init section
  - move remove() to exit section

When this driver is statically linked, this patch shrinks the driver's
runtime I-space footprint by over 20% (950 bytes).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
  • Loading branch information
David Brownell authored and Pierre Ossman committed Jan 4, 2007
1 parent 3947a39 commit a26b498
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/mmc/at91_mci.c
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ static irqreturn_t at91_mmc_det_irq(int irq, void *_host)
return IRQ_HANDLED;
}

int at91_mci_get_ro(struct mmc_host *mmc)
static int at91_mci_get_ro(struct mmc_host *mmc)
{
int read_only = 0;
struct at91mci_host *host = mmc_priv(mmc);
Expand All @@ -794,7 +794,7 @@ static const struct mmc_host_ops at91_mci_ops = {
/*
* Probe for the device
*/
static int at91_mci_probe(struct platform_device *pdev)
static int __init at91_mci_probe(struct platform_device *pdev)
{
struct mmc_host *mmc;
struct at91mci_host *host;
Expand Down Expand Up @@ -910,7 +910,7 @@ static int at91_mci_probe(struct platform_device *pdev)
/*
* Remove a device
*/
static int at91_mci_remove(struct platform_device *pdev)
static int __exit at91_mci_remove(struct platform_device *pdev)
{
struct mmc_host *mmc = platform_get_drvdata(pdev);
struct at91mci_host *host;
Expand Down Expand Up @@ -972,8 +972,7 @@ static int at91_mci_resume(struct platform_device *pdev)
#endif

static struct platform_driver at91_mci_driver = {
.probe = at91_mci_probe,
.remove = at91_mci_remove,
.remove = __exit_p(at91_mci_remove),
.suspend = at91_mci_suspend,
.resume = at91_mci_resume,
.driver = {
Expand All @@ -984,7 +983,7 @@ static struct platform_driver at91_mci_driver = {

static int __init at91_mci_init(void)
{
return platform_driver_register(&at91_mci_driver);
return platform_driver_probe(&at91_mci_driver, at91_mci_probe);
}

static void __exit at91_mci_exit(void)
Expand Down

0 comments on commit a26b498

Please sign in to comment.