Skip to content

Commit

Permalink
vmscan: kill unnecessary prefetch
Browse files Browse the repository at this point in the history
The pages in the list passed move_active_pages_to_lru() are already
touched by shrink_active_list().  IOW the prefetch in
move_active_pages_to_lru() don't populate any cache.  it's pointless.

This patch remove it.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
KOSAKI Motohiro authored and Linus Torvalds committed Sep 22, 2009
1 parent 74a1c48 commit a26f532
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion mm/vmscan.c
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,6 @@ static void move_active_pages_to_lru(struct zone *zone,

while (!list_empty(list)) {
page = lru_to_page(list);
prefetchw_prev_lru_page(page, list, flags);

VM_BUG_ON(PageLRU(page));
SetPageLRU(page);
Expand Down

0 comments on commit a26f532

Please sign in to comment.