Skip to content

Commit

Permalink
ARM: highbank: call highbank_pm_init from .init_machine
Browse files Browse the repository at this point in the history
Being a module_init call, highbank_pm_init will cause problem with
multi-platform build running on other platforms.  Call it from
.init_machine instead.

Reported-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
  • Loading branch information
Rob Herring authored and Olof Johansson committed Sep 21, 2012
1 parent 85594df commit a283580
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
6 changes: 6 additions & 0 deletions arch/arm/mach-highbank/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,10 @@ extern void highbank_lluart_map_io(void);
static inline void highbank_lluart_map_io(void) {}
#endif

#ifdef CONFIG_PM_SLEEP
extern void highbank_pm_init(void);
#else
static inline void highbank_pm_init(void) {}
#endif

extern void highbank_smc1(int fn, int arg);
1 change: 1 addition & 0 deletions arch/arm/mach-highbank/highbank.c
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ static void highbank_power_off(void)
static void __init highbank_init(void)
{
pm_power_off = highbank_power_off;
highbank_pm_init();

of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
}
Expand Down
4 changes: 1 addition & 3 deletions arch/arm/mach-highbank/pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ static const struct platform_suspend_ops highbank_pm_ops = {
.valid = suspend_valid_only_mem,
};

static int __init highbank_pm_init(void)
void __init highbank_pm_init(void)
{
suspend_set_ops(&highbank_pm_ops);
return 0;
}
module_init(highbank_pm_init);

0 comments on commit a283580

Please sign in to comment.