Skip to content

Commit

Permalink
PM: convert do_each_thread to for_each_process_thread
Browse files Browse the repository at this point in the history
as per 0c740d0 (introduce for_each_thread() to replace the buggy
while_each_thread()) get rid of do_each_thread { } while_each_thread()
construct and replace it by a more error prone for_each_thread.

This patch doesn't introduce any user visible change.

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Michal Hocko authored and Rafael J. Wysocki committed Oct 21, 2014
1 parent 5695be1 commit a28e785
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions kernel/power/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ static int try_to_freeze_tasks(bool user_only)
while (true) {
todo = 0;
read_lock(&tasklist_lock);
do_each_thread(g, p) {
for_each_process_thread(g, p) {
if (p == current || !freeze_task(p))
continue;

if (!freezer_should_skip(p))
todo++;
} while_each_thread(g, p);
}
read_unlock(&tasklist_lock);

if (!user_only) {
Expand Down Expand Up @@ -93,11 +93,11 @@ static int try_to_freeze_tasks(bool user_only)

if (!wakeup) {
read_lock(&tasklist_lock);
do_each_thread(g, p) {
for_each_process_thread(g, p) {
if (p != current && !freezer_should_skip(p)
&& freezing(p) && !frozen(p))
sched_show_task(p);
} while_each_thread(g, p);
}
read_unlock(&tasklist_lock);
}
} else {
Expand Down Expand Up @@ -229,11 +229,11 @@ void thaw_processes(void)
thaw_workqueues();

read_lock(&tasklist_lock);
do_each_thread(g, p) {
for_each_process_thread(g, p) {
/* No other threads should have PF_SUSPEND_TASK set */
WARN_ON((p != curr) && (p->flags & PF_SUSPEND_TASK));
__thaw_task(p);
} while_each_thread(g, p);
}
read_unlock(&tasklist_lock);

WARN_ON(!(curr->flags & PF_SUSPEND_TASK));
Expand All @@ -256,10 +256,10 @@ void thaw_kernel_threads(void)
thaw_workqueues();

read_lock(&tasklist_lock);
do_each_thread(g, p) {
for_each_process_thread(g, p) {
if (p->flags & (PF_KTHREAD | PF_WQ_WORKER))
__thaw_task(p);
} while_each_thread(g, p);
}
read_unlock(&tasklist_lock);

schedule();
Expand Down

0 comments on commit a28e785

Please sign in to comment.