Skip to content

Commit

Permalink
[NET]: Fix TX checksum feature check
Browse files Browse the repository at this point in the history
This patch fixes a boolean error in the new TX checksum check
that causes bogus TSO packets to be generated.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Herbert Xu authored and David S. Miller committed Jul 11, 2007
1 parent 58e50a9 commit a298830
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1509,11 +1509,11 @@ int dev_queue_xmit(struct sk_buff *skb)
skb_set_transport_header(skb, skb->csum_start -
skb_headroom(skb));

if (!(dev->features & NETIF_F_GEN_CSUM)
|| ((dev->features & NETIF_F_IP_CSUM)
&& skb->protocol == htons(ETH_P_IP))
|| ((dev->features & NETIF_F_IPV6_CSUM)
&& skb->protocol == htons(ETH_P_IPV6)))
if (!(dev->features & NETIF_F_GEN_CSUM) &&
!((dev->features & NETIF_F_IP_CSUM) &&
skb->protocol == htons(ETH_P_IP)) &&
!((dev->features & NETIF_F_IPV6_CSUM) &&
skb->protocol == htons(ETH_P_IPV6)))
if (skb_checksum_help(skb))
goto out_kfree_skb;
}
Expand Down

0 comments on commit a298830

Please sign in to comment.