Skip to content

Commit

Permalink
staging/comedi: Use dev_ printks in drivers/ni_mio_cs.c
Browse files Browse the repository at this point in the history
fixed below checkpatch warnings.
- WARNING: printk() should include KERN_ facility level

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
YAMANE Toshiaki authored and Greg Kroah-Hartman committed Nov 1, 2012
1 parent d03bf7a commit a29f7a9
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions drivers/staging/comedi/drivers/ni_mio_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -340,13 +340,15 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)

irq = link->irq;

printk("comedi%d: %s: DAQCard: io 0x%04lx, irq %u, ",
dev->minor, dev->driver->driver_name, dev->iobase, irq);
dev->board_ptr = ni_boards + ni_getboardtype(dev, link);

#if 0
{
int i;

printk("comedi%d: %s: DAQCard: io 0x%04lx, irq %u, ",
dev->minor, dev->driver->driver_name, dev->iobase, irq);

printk(" board fingerprint:");
for (i = 0; i < 32; i += 2) {
printk(" %04x %02x", inw(dev->iobase + i),
Expand All @@ -357,18 +359,17 @@ static int mio_cs_attach(struct comedi_device *dev, struct comedi_devconfig *it)
for (i = 0; i < 10; i++)
printk(" 0x%04x", win_in(i));
printk("\n");

printk("boardtype.name: %s\n", boardtype.name);
}
#endif

dev->board_ptr = ni_boards + ni_getboardtype(dev, link);

printk(" %s", boardtype.name);
dev->board_name = boardtype.name;

ret = request_irq(irq, ni_E_interrupt, NI_E_IRQ_FLAGS,
"ni_mio_cs", dev);
if (ret < 0) {
printk(" irq not available\n");
dev_err(dev->class_dev, "irq not available\n");
return -EINVAL;
}
dev->irq = irq;
Expand Down Expand Up @@ -401,7 +402,8 @@ static int ni_getboardtype(struct comedi_device *dev,
return i;
}

printk("unknown board 0x%04x -- pretend it is a ", link->card_id);
dev_err(dev->class_dev,
"unknown board 0x%04x -- pretend it is a ", link->card_id);

return 0;
}
Expand Down

0 comments on commit a29f7a9

Please sign in to comment.