Skip to content

Commit

Permalink
[media] gspca: Use req_events in poll
Browse files Browse the repository at this point in the history
So that we don't start a read stream when an app is only polling for control
events.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Hans de Goede authored and Mauro Carvalho Chehab committed May 14, 2012
1 parent 9a190c8 commit a2d887c
Showing 1 changed file with 26 additions and 18 deletions.
44 changes: 26 additions & 18 deletions drivers/media/video/gspca/gspca.c
Original file line number Diff line number Diff line change
Expand Up @@ -2030,31 +2030,39 @@ static int read_alloc(struct gspca_dev *gspca_dev,
static unsigned int dev_poll(struct file *file, poll_table *wait)
{
struct gspca_dev *gspca_dev = video_drvdata(file);
int ret;
unsigned long req_events = poll_requested_events(wait);
int ret = 0;

PDEBUG(D_FRAM, "poll");

poll_wait(file, &gspca_dev->wq, wait);
if (req_events & POLLPRI)
ret |= v4l2_ctrl_poll(file, wait);

/* if reqbufs is not done, the user would use read() */
if (gspca_dev->memory == GSPCA_MEMORY_NO) {
ret = read_alloc(gspca_dev, file);
if (ret != 0)
return POLLERR;
}
if (req_events & (POLLIN | POLLRDNORM)) {
/* if reqbufs is not done, the user would use read() */
if (gspca_dev->memory == GSPCA_MEMORY_NO) {
if (read_alloc(gspca_dev, file) != 0) {
ret |= POLLERR;
goto out;
}
}

if (mutex_lock_interruptible(&gspca_dev->queue_lock) != 0)
return POLLERR;
poll_wait(file, &gspca_dev->wq, wait);

/* check if an image has been received */
if (gspca_dev->fr_o != atomic_read(&gspca_dev->fr_i))
ret = POLLIN | POLLRDNORM; /* yes */
else
ret = 0;
ret |= v4l2_ctrl_poll(file, wait);
mutex_unlock(&gspca_dev->queue_lock);
/* check if an image has been received */
if (mutex_lock_interruptible(&gspca_dev->queue_lock) != 0) {
ret |= POLLERR;
goto out;
}
if (gspca_dev->fr_o != atomic_read(&gspca_dev->fr_i))
ret |= POLLIN | POLLRDNORM;
mutex_unlock(&gspca_dev->queue_lock);
}

out:
if (!gspca_dev->present)
return POLLHUP;
ret |= POLLHUP;

return ret;
}

Expand Down

0 comments on commit a2d887c

Please sign in to comment.