Skip to content

Commit

Permalink
hwmon: (k8temp) Fix wrong sensor selection for AMD K8 RevF/RevG CPUs
Browse files Browse the repository at this point in the history
Meaning of ThermSenseCoreSel bit was inverted beginning with K8 RevF.
That means with current driver temp1/temp2 belong to core 1 and
temp3/temp4 belong to core 0 on a K8 RevF/RevG CPU.

This patch ensures that temp1/temp2 always belong to core 0 and
temp3/temp4 to core 1 for all K8 revisions.

Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
  • Loading branch information
Andreas Herrmann authored and Jean Delvare committed Jan 15, 2009
1 parent bb9a35f commit a2e066b
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions drivers/hwmon/k8temp.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ struct k8temp_data {
/* registers values */
u8 sensorsp; /* sensor presence bits - SEL_CORE & SEL_PLACE */
u32 temp[2][2]; /* core, place */
u8 swap_core_select; /* meaning of SEL_CORE is inverted */
};

static struct k8temp_data *k8temp_update_device(struct device *dev)
Expand Down Expand Up @@ -117,6 +118,9 @@ static ssize_t show_temp(struct device *dev,
int place = attr->index;
struct k8temp_data *data = k8temp_update_device(dev);

if (data->swap_core_select)
core = core ? 0 : 1;

return sprintf(buf, "%d\n",
TEMP_FROM_REG(data->temp[core][place]));
}
Expand Down Expand Up @@ -162,7 +166,12 @@ static int __devinit k8temp_probe(struct pci_dev *pdev,
goto exit_free;
}

/*
* AMD NPT family 0fh, i.e. RevF and RevG:
* meaning of SEL_CORE bit is inverted
*/
if (model >= 0x40) {
data->swap_core_select = 1;
dev_warn(&pdev->dev, "Temperature readouts might be "
"wrong - check erratum #141\n");
}
Expand Down

0 comments on commit a2e066b

Please sign in to comment.