Skip to content

Commit

Permalink
bq27x00: Fix CURRENT_NOW property
Browse files Browse the repository at this point in the history
According to the bq27000 datasheet the current should be calculated by
the following formula:
    current = AI * 3570 / 20

This patch adjust the drivers code accordingly.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Rodolfo Giometti <giometti@linux.it>
Tested-by: Grazvydas Ignotas <notasas@gmail.com>
  • Loading branch information
Pali Rohár authored and Lars-Peter Clausen committed Feb 22, 2011
1 parent 0e9f304 commit a2e5118
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/power/bq27x00_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
#define BQ27500_FLAG_DSC BIT(0)
#define BQ27500_FLAG_FC BIT(9)

#define BQ27000_RS 20 /* Resistor sense */

/* If the system has several batteries we need a different name for each
* of them...
*/
Expand Down Expand Up @@ -149,7 +151,7 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di)

if (di->chip == BQ27500) {
/* bq27500 returns signed value */
curr = (int)(s16)curr;
curr = (int)((s16)curr) * 1000;
} else {
ret = bq27x00_read(BQ27x00_REG_FLAGS, &flags, 0, di);
if (ret < 0) {
Expand All @@ -160,9 +162,10 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di)
dev_dbg(di->dev, "negative current!\n");
curr = -curr;
}
curr = curr * 3570 / BQ27000_RS;
}

return curr * 1000;
return curr;
}

/*
Expand Down

0 comments on commit a2e5118

Please sign in to comment.