Skip to content

Commit

Permalink
[PATCH] Clean up char/esp.c
Browse files Browse the repository at this point in the history
coverity choked at another two !tty checks, in places where tty can
never be NULL. Since it removes some code we should remove
these checks. (Coverity ids #763,#762)

Signed-off-by Eric Sesterhenn <snakebyte@gmx.de>

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Eric Sesterhenn authored and Linus Torvalds committed Jun 25, 2006
1 parent 969dd06 commit a2f20c7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/char/esp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1212,7 +1212,7 @@ static void rs_put_char(struct tty_struct *tty, unsigned char ch)
if (serial_paranoia_check(info, tty->name, "rs_put_char"))
return;

if (!tty || !info->xmit_buf)
if (!info->xmit_buf)
return;

spin_lock_irqsave(&info->lock, flags);
Expand Down Expand Up @@ -1256,7 +1256,7 @@ static int rs_write(struct tty_struct * tty,
if (serial_paranoia_check(info, tty->name, "rs_write"))
return 0;

if (!tty || !info->xmit_buf)
if (!info->xmit_buf)
return 0;

while (1) {
Expand Down

0 comments on commit a2f20c7

Please sign in to comment.