Skip to content

Commit

Permalink
[media] s5p-csis: Add registers logging for debugging
Browse files Browse the repository at this point in the history
Dump registers contents together with the event counters state
in VIDIOC_LOG_STATUS ioctl.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sylwester Nawrocki authored and Mauro Carvalho Chehab committed Dec 21, 2012
1 parent cd65a64 commit a2fea0d
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions drivers/media/platform/s5p-fimc/mipi-csis.c
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,30 @@ static int s5pcsis_clk_get(struct csis_state *state)
return -ENXIO;
}

static void dump_regs(struct csis_state *state, const char *label)
{
struct {
u32 offset;
const char * const name;
} registers[] = {
{ 0x00, "CTRL" },
{ 0x04, "DPHYCTRL" },
{ 0x08, "CONFIG" },
{ 0x0c, "DPHYSTS" },
{ 0x10, "INTMSK" },
{ 0x2c, "RESOL" },
{ 0x38, "SDW_CONFIG" },
};
u32 i;

v4l2_info(&state->sd, "--- %s ---\n", label);

for (i = 0; i < ARRAY_SIZE(registers); i++) {
u32 cfg = s5pcsis_read(state, registers[i].offset);
v4l2_info(&state->sd, "%10s: 0x%08x\n", registers[i].name, cfg);
}
}

static void s5pcsis_start_stream(struct csis_state *state)
{
s5pcsis_reset(state);
Expand Down Expand Up @@ -583,7 +607,11 @@ static int s5pcsis_log_status(struct v4l2_subdev *sd)
{
struct csis_state *state = sd_to_csis_state(sd);

mutex_lock(&state->lock);
s5pcsis_log_counters(state, true);
if (debug && (state->flags & ST_POWERED))
dump_regs(state, __func__);
mutex_unlock(&state->lock);
return 0;
}

Expand Down

0 comments on commit a2fea0d

Please sign in to comment.