Skip to content

Commit

Permalink
staging: correct dubious use of !x & y
Browse files Browse the repository at this point in the history
Noticed by sparse:
drivers/staging/me4000/me4000.c:1213:43: warning: dubious: !x & y
drivers/staging/wlan-ng/p80211wext.c:1583:21: warning: dubious: !x & y

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Harvey Harrison authored and Greg Kroah-Hartman committed Jan 6, 2009
1 parent 6e38a2b commit a337957
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/staging/me4000/me4000.c
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,7 @@ static int me4000_xilinx_download(struct me4000_info *info)

/* Wait until /INIT pin is set */
udelay(20);
if (!inl(info->plx_regbase + PLX_INTCSR) & 0x20) {
if (!(inl(info->plx_regbase + PLX_INTCSR) & 0x20)) {
printk(KERN_ERR "%s:Can't init Xilinx\n", __func__);
return -EIO;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/wlan-ng/p80211wext.c
Original file line number Diff line number Diff line change
Expand Up @@ -1580,7 +1580,7 @@ static int p80211wext_set_encodeext(struct net_device *dev,


if ( ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY ) {
if ( ! ext->alg & IW_ENCODE_ALG_WEP) {
if (!(ext->alg & IW_ENCODE_ALG_WEP)) {
WLAN_LOG_DEBUG(1,"asked to set a non wep key :(");
return -EINVAL;
}
Expand Down

0 comments on commit a337957

Please sign in to comment.