Skip to content

Commit

Permalink
TTY: mxser, fix invalid module_parm permissions
Browse files Browse the repository at this point in the history
444 means 0674 and we do not definitely want that. Use S_IRUGO which
is much more safer.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: Rusty Russell <rusty@ozlabs.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Aug 13, 2012
1 parent 27bf7c4 commit a342ca1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/tty/mxser.c
Original file line number Diff line number Diff line change
Expand Up @@ -2338,7 +2338,7 @@ static struct tty_port_operations mxser_port_ops = {
*/

static bool allow_overlapping_vector;
module_param(allow_overlapping_vector, bool, 444);
module_param(allow_overlapping_vector, bool, S_IRUGO);
MODULE_PARM_DESC(allow_overlapping_vector, "whether we allow ISA cards to be configured such that vector overlabs IO ports (default=no)");

static bool mxser_overlapping_vector(struct mxser_board *brd)
Expand Down

0 comments on commit a342ca1

Please sign in to comment.