Skip to content

Commit

Permalink
[PATCH] libata: PHY reset requires writing 0x4 to SControl
Browse files Browse the repository at this point in the history
Hi,

Reading the Intel VSC and AHCI it seems like writing 0x302 is incorrect.
The only valid values are 4, 1 and 0.  Writing 4 disables the
PHY.

Signed-off-by: Martin Hicks <mort@bork.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Martin Hicks authored and Jeff Garzik committed Aug 10, 2006
1 parent 51704c6 commit a34b6fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2746,7 +2746,7 @@ int sata_std_hardreset(struct ata_port *ap, unsigned int *class)
if ((rc = sata_scr_read(ap, SCR_CONTROL, &scontrol)))
return rc;

scontrol = (scontrol & 0x0f0) | 0x302;
scontrol = (scontrol & 0x0f0) | 0x304;

if ((rc = sata_scr_write(ap, SCR_CONTROL, scontrol)))
return rc;
Expand Down

0 comments on commit a34b6fc

Please sign in to comment.