Skip to content

Commit

Permalink
leds-lp5523: set the brightness to 0 forcely on removing the driver
Browse files Browse the repository at this point in the history
Turning off the brightness of each channel is required
when removing the driver.

So use flush_work() rather than cancel_work_sync() to execute
remaining brightness works.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
  • Loading branch information
Kim, Milo authored and Bryan Wu committed Sep 11, 2012
1 parent 94b43b6 commit a39b985
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/leds/leds-lp5523.c
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ static int __devinit lp5523_probe(struct i2c_client *client,
fail2:
for (i = 0; i < chip->num_leds; i++) {
led_classdev_unregister(&chip->leds[i].cdev);
cancel_work_sync(&chip->leds[i].brightness_work);
flush_work(&chip->leds[i].brightness_work);
}
fail1:
if (pdata->enable)
Expand All @@ -993,7 +993,7 @@ static int lp5523_remove(struct i2c_client *client)

for (i = 0; i < chip->num_leds; i++) {
led_classdev_unregister(&chip->leds[i].cdev);
cancel_work_sync(&chip->leds[i].brightness_work);
flush_work(&chip->leds[i].brightness_work);
}

if (chip->pdata->enable)
Expand Down

0 comments on commit a39b985

Please sign in to comment.