Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 344467
b: refs/heads/master
c: 04553e9
h: refs/heads/master
i:
  344465: 7f759f2
  344463: 13104e2
v: v3
  • Loading branch information
Roland Stigge authored and Bryan Wu committed Nov 26, 2012
1 parent b36ac8a commit a3b97de
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: e8941928faf248530c0eff95462e9fee0b1cc8da
refs/heads/master: 04553e925baaa815025c6fd3cdc301a794fa2c74
17 changes: 11 additions & 6 deletions trunk/drivers/leds/leds-gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <linux/workqueue.h>
#include <linux/module.h>
#include <linux/pinctrl/consumer.h>
#include <linux/err.h>

struct gpio_led_data {
struct led_classdev cdev;
Expand Down Expand Up @@ -174,12 +175,16 @@ static struct gpio_leds_priv * __devinit gpio_leds_create_of(struct platform_dev
/* count LEDs in this device, so we know how much to allocate */
count = of_get_child_count(np);
if (!count)
return NULL;
return ERR_PTR(-ENODEV);

for_each_child_of_node(np, child)
if (of_get_gpio(child, 0) == -EPROBE_DEFER)
return ERR_PTR(-EPROBE_DEFER);

priv = devm_kzalloc(&pdev->dev, sizeof_gpio_leds_priv(count),
GFP_KERNEL);
if (!priv)
return NULL;
return ERR_PTR(-ENOMEM);

for_each_child_of_node(np, child) {
struct gpio_led led = {};
Expand Down Expand Up @@ -214,7 +219,7 @@ static struct gpio_leds_priv * __devinit gpio_leds_create_of(struct platform_dev
err:
for (count = priv->num_leds - 2; count >= 0; count--)
delete_gpio_led(&priv->leds[count]);
return NULL;
return ERR_PTR(-ENODEV);
}

static const struct of_device_id of_gpio_leds_match[] = {
Expand All @@ -224,7 +229,7 @@ static const struct of_device_id of_gpio_leds_match[] = {
#else /* CONFIG_OF_GPIO */
static struct gpio_leds_priv * __devinit gpio_leds_create_of(struct platform_device *pdev)
{
return NULL;
return ERR_PTR(-ENODEV);
}
#endif /* CONFIG_OF_GPIO */

Expand Down Expand Up @@ -262,8 +267,8 @@ static int __devinit gpio_led_probe(struct platform_device *pdev)
}
} else {
priv = gpio_leds_create_of(pdev);
if (!priv)
return -ENODEV;
if (IS_ERR(priv))
return PTR_ERR(priv);
}

platform_set_drvdata(pdev, priv);
Expand Down

0 comments on commit a3b97de

Please sign in to comment.