Skip to content

Commit

Permalink
wusb: whci-hcd: always lock whc->lock with interrupts disabled
Browse files Browse the repository at this point in the history
Always lock whc->lock with spin_lock_irq() or spin_lock_irqsave().

Signed-off-by: David Vrabel <david.vrabel@csr.com>
  • Loading branch information
David Vrabel committed Feb 16, 2009
1 parent d2f8d7e commit a3c1239
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/host/whci/asl.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,13 @@ void scan_async_work(struct work_struct *work)
* Now that the ASL is updated, complete the removal of any
* removed qsets.
*/
spin_lock(&whc->lock);
spin_lock_irq(&whc->lock);

list_for_each_entry_safe(qset, t, &whc->async_removed_list, list_node) {
qset_remove_complete(whc, qset);
}

spin_unlock(&whc->lock);
spin_unlock_irq(&whc->lock);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions drivers/usb/host/whci/pzl.c
Original file line number Diff line number Diff line change
Expand Up @@ -255,13 +255,13 @@ void scan_periodic_work(struct work_struct *work)
* Now that the PZL is updated, complete the removal of any
* removed qsets.
*/
spin_lock(&whc->lock);
spin_lock_irq(&whc->lock);

list_for_each_entry_safe(qset, t, &whc->periodic_removed_list, list_node) {
qset_remove_complete(whc, qset);
}

spin_unlock(&whc->lock);
spin_unlock_irq(&whc->lock);
}

/**
Expand Down

0 comments on commit a3c1239

Please sign in to comment.