Skip to content

Commit

Permalink
x86, UV: fix redundant creation of sgi_uv
Browse files Browse the repository at this point in the history
Impact: fix double entry creation in /proc

There is a collision between two UV functions:
  both uv_ptc_init() and gru_proc_init() try to make /proc/sgi_uv

So move it's creation to a single place: uv_system_init()

Signed-off-by: Cliff Wickman <cpw@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Cliff Wickman authored and Ingo Molnar committed Nov 11, 2008
1 parent 7d9d1f2 commit a3d732f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 2 additions & 0 deletions arch/x86/kernel/genx2apic_uv_x.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <linux/module.h>
#include <linux/hardirq.h>
#include <linux/timer.h>
#include <linux/proc_fs.h>
#include <asm/current.h>
#include <asm/smp.h>
#include <asm/ipi.h>
Expand Down Expand Up @@ -570,4 +571,5 @@ void __init uv_system_init(void)

uv_cpu_init();
uv_scir_register_cpu_notifier();
proc_mkdir("sgi_uv", NULL);
}
4 changes: 0 additions & 4 deletions arch/x86/kernel/tlb_uv.c
Original file line number Diff line number Diff line change
Expand Up @@ -566,14 +566,10 @@ static int __init uv_ptc_init(void)
if (!is_uv_system())
return 0;

if (!proc_mkdir("sgi_uv", NULL))
return -EINVAL;

proc_uv_ptc = create_proc_entry(UV_PTC_BASENAME, 0444, NULL);
if (!proc_uv_ptc) {
printk(KERN_ERR "unable to create %s proc entry\n",
UV_PTC_BASENAME);
remove_proc_entry("sgi_uv", NULL);
return -EINVAL;
}
proc_uv_ptc->proc_fops = &proc_uv_ptc_operations;
Expand Down
1 change: 0 additions & 1 deletion drivers/misc/sgi-gru/gruprocfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ int gru_proc_init(void)
{
struct proc_entry *p;

proc_mkdir("sgi_uv", NULL);
proc_gru = proc_mkdir("sgi_uv/gru", NULL);

for (p = proc_files; p->name; p++)
Expand Down

0 comments on commit a3d732f

Please sign in to comment.