Skip to content

Commit

Permalink
[ROSE]: rose_heartbeat_expiry() locking fix
Browse files Browse the repository at this point in the history
Missing unlock, as noted by Ted Unangst <tedu@coverity.com>.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
  • Loading branch information
Andrew Morton authored and Arnaldo Carvalho de Melo committed Oct 31, 2005
1 parent 6b7d31f commit a3d7a9d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/rose/rose_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ static void rose_heartbeat_expiry(unsigned long param)
is accepted() it isn't 'dead' so doesn't get removed. */
if (sock_flag(sk, SOCK_DESTROY) ||
(sk->sk_state == TCP_LISTEN && sock_flag(sk, SOCK_DEAD))) {
bh_unlock_sock(sk);
rose_destroy_socket(sk);
return;
}
Expand Down

0 comments on commit a3d7a9d

Please sign in to comment.