Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 184236
b: refs/heads/master
c: 3d5d30f
h: refs/heads/master
v: v3
  • Loading branch information
Jan Kiszka authored and David S. Miller committed Feb 17, 2010
1 parent b26bca6 commit a45c26b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 6576c2891adacad81ea0b24f0704ecac9fc727cb
refs/heads/master: 3d5d30fe7a6aa4c9d63dc4fe6b6da6abac423bc2
21 changes: 9 additions & 12 deletions trunk/drivers/isdn/capi/capi.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ static LIST_HEAD(capidev_list);

#ifdef CONFIG_ISDN_CAPI_MIDDLEWARE

static DEFINE_RWLOCK(capiminors_lock);
static DEFINE_SPINLOCK(capiminors_lock);
static struct capiminor **capiminors;

static struct tty_driver *capinc_tty_driver;
Expand Down Expand Up @@ -218,7 +218,6 @@ static struct capiminor *capiminor_alloc(struct capi20_appl *ap, u32 ncci)
struct capiminor *mp;
struct device *dev;
unsigned int minor;
unsigned long flags;

mp = kzalloc(sizeof(*mp), GFP_KERNEL);
if (!mp) {
Expand All @@ -242,13 +241,13 @@ static struct capiminor *capiminor_alloc(struct capi20_appl *ap, u32 ncci)
mp->port.ops = &capiminor_port_ops;

/* Allocate the least unused minor number. */
write_lock_irqsave(&capiminors_lock, flags);
spin_lock(&capiminors_lock);
for (minor = 0; minor < capi_ttyminors; minor++)
if (!capiminors[minor]) {
capiminors[minor] = mp;
break;
}
write_unlock_irqrestore(&capiminors_lock, flags);
spin_unlock(&capiminors_lock);

if (minor == capi_ttyminors) {
printk(KERN_NOTICE "capi: out of minors\n");
Expand All @@ -264,9 +263,9 @@ static struct capiminor *capiminor_alloc(struct capi20_appl *ap, u32 ncci)
return mp;

err_out2:
write_lock_irqsave(&capiminors_lock, flags);
spin_lock(&capiminors_lock);
capiminors[minor] = NULL;
write_unlock_irqrestore(&capiminors_lock, flags);
spin_unlock(&capiminors_lock);

err_out1:
kfree(mp);
Expand All @@ -288,11 +287,11 @@ static struct capiminor *capiminor_get(unsigned int minor)
{
struct capiminor *mp;

read_lock(&capiminors_lock);
spin_lock(&capiminors_lock);
mp = capiminors[minor];
if (mp)
kref_get(&mp->kref);
read_unlock(&capiminors_lock);
spin_unlock(&capiminors_lock);

return mp;
}
Expand All @@ -304,13 +303,11 @@ static inline void capiminor_put(struct capiminor *mp)

static void capiminor_free(struct capiminor *mp)
{
unsigned long flags;

tty_unregister_device(capinc_tty_driver, mp->minor);

write_lock_irqsave(&capiminors_lock, flags);
spin_lock(&capiminors_lock);
capiminors[mp->minor] = NULL;
write_unlock_irqrestore(&capiminors_lock, flags);
spin_unlock(&capiminors_lock);

capiminor_put(mp);
}
Expand Down

0 comments on commit a45c26b

Please sign in to comment.