Skip to content

Commit

Permalink
[SCSI] qla2xxx: Don't schedule the DPC routine to perform an issue-li…
Browse files Browse the repository at this point in the history
…p request.

As the driver depends on the DPC routine to handle bottom-half
loop resynchronization in order to recover from the issue-lip
request.  The issue_lip call is sleeping context capable, so just
issue the reset function there.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Andrew Vasquez authored and James Bottomley committed Jan 23, 2008
1 parent da7429f commit a4722cf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/scsi/qla2xxx/qla_attr.c
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ qla2x00_issue_lip(struct Scsi_Host *shost)
{
scsi_qla_host_t *ha = shost_priv(shost);

set_bit(LOOP_RESET_NEEDED, &ha->dpc_flags);
qla2x00_loop_reset(ha);
return 0;
}

Expand Down
2 changes: 2 additions & 0 deletions drivers/scsi/qla2xxx/qla_gbl.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ extern int ql2xextended_error_logging;
extern int ql2xqfullrampup;
extern int num_hosts;

extern int qla2x00_loop_reset(scsi_qla_host_t *);

/*
* Global Functions in qla_mid.c source file.
*/
Expand Down
3 changes: 1 addition & 2 deletions drivers/scsi/qla2xxx/qla_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ static int qla2xxx_eh_abort(struct scsi_cmnd *);
static int qla2xxx_eh_device_reset(struct scsi_cmnd *);
static int qla2xxx_eh_bus_reset(struct scsi_cmnd *);
static int qla2xxx_eh_host_reset(struct scsi_cmnd *);
static int qla2x00_loop_reset(scsi_qla_host_t *ha);
static int qla2x00_device_reset(scsi_qla_host_t *, fc_port_t *);

static int qla2x00_change_queue_depth(struct scsi_device *, int);
Expand Down Expand Up @@ -1060,7 +1059,7 @@ qla2xxx_eh_host_reset(struct scsi_cmnd *cmd)
* Returns:
* 0 = success
*/
static int
int
qla2x00_loop_reset(scsi_qla_host_t *ha)
{
int ret;
Expand Down

0 comments on commit a4722cf

Please sign in to comment.