Skip to content

Commit

Permalink
staging: cxt1e1: use kernel's way of returning error codes
Browse files Browse the repository at this point in the history
The error codes the kernel functions return are -ve numbers, convert this
function to follow the other kernel functions

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Devendra Naga authored and Greg Kroah-Hartman committed Sep 4, 2012
1 parent 375d888 commit a47bf24
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/staging/cxt1e1/linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ c4_linux_xmit (struct sk_buff * skb, struct net_device * ndev)
priv = hdlc->priv;

rval = musycc_start_xmit (priv->ci, priv->channum, skb);
return -rval;
return rval;
}

static const struct net_device_ops chan_ops = {
Expand Down
10 changes: 5 additions & 5 deletions drivers/staging/cxt1e1/musycc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1761,15 +1761,15 @@ musycc_start_xmit (ci_t * ci, int channum, void *mem_token)
u_int32_t len;

if (!(ch = sd_find_chan (ci, channum)))
return ENOENT;
return -ENOENT;

if (ci->state != C_RUNNING) /* full interrupt processing available */
return EINVAL;
return -EINVAL;
if (ch->state != UP)
return EINVAL;
return -EINVAL;

if (!(ch->status & TX_ENABLED))
return EROFS; /* how else to flag unwritable state ? */
return -EROFS; /* how else to flag unwritable state ? */

#ifdef RLD_TRANS_DEBUGx
if (1 || cxt1e1_log_level >= LOG_MONITOR2)
Expand Down Expand Up @@ -1836,7 +1836,7 @@ musycc_start_xmit (ci_t * ci, int channum, void *mem_token)
#if 0
spin_unlock_irqrestore (&ch->ch_txlock, flags);
#endif
return EBUSY; /* tell user to try again later */
return -EBUSY; /* tell user to try again later */
}
/**************************************************/
/** Put the user data into MUSYCC data buffer(s) **/
Expand Down

0 comments on commit a47bf24

Please sign in to comment.