Skip to content

Commit

Permalink
ASoC: rsnd: delete unneeded test before of_node_put
Browse files Browse the repository at this point in the history
Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Julia Lawall authored and Mark Brown committed Aug 16, 2014
1 parent 7d1311b commit a493b6a
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions sound/soc/sh/rcar/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,8 @@ if (name##_node) { \
mod_parse(src);
mod_parse(dvc);

if (playback)
of_node_put(playback);
if (capture)
of_node_put(capture);
of_node_put(playback);
of_node_put(capture);
}

dai_i++;
Expand Down

0 comments on commit a493b6a

Please sign in to comment.