Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 234002
b: refs/heads/master
c: 1f858ef
h: refs/heads/master
v: v3
  • Loading branch information
Naga Chumbalkar authored and Dave Jones committed Mar 9, 2011
1 parent 6c1b5c8 commit a4d3cd5
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 45 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 687530b44de7e0fe70fabb4200d4cabce3af1a0c
refs/heads/master: 1f858ef2fbabdc5e645644010a31a40c32e397c9
2 changes: 1 addition & 1 deletion trunk/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ static unsigned int pcc_get_freq(unsigned int cpu)
cmd_incomplete:
iowrite16(0, &pcch_hdr->status);
spin_unlock(&pcc_lock);
return -EINVAL;
return 0;
}

static int pcc_cpufreq_target(struct cpufreq_policy *policy,
Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/mmc/core/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1529,7 +1529,7 @@ void mmc_rescan(struct work_struct *work)
* still present
*/
if (host->bus_ops && host->bus_ops->detect && !host->bus_dead
&& !(host->caps & MMC_CAP_NONREMOVABLE))
&& mmc_card_is_removable(host))
host->bus_ops->detect(host);

/*
Expand Down
14 changes: 3 additions & 11 deletions trunk/fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -1546,7 +1546,6 @@ static int path_walk(const char *name, struct nameidata *nd)
/* nd->path had been dropped */
current->total_link_count = 0;
nd->path = save;
nd->inode = save.dentry->d_inode;
path_get(&nd->path);
nd->flags |= LOOKUP_REVAL;
result = link_path_walk(name, nd);
Expand Down Expand Up @@ -2456,29 +2455,22 @@ struct file *do_filp_open(int dfd, const char *pathname,
/* !O_CREAT, simple open */
error = do_path_lookup(dfd, pathname, flags, &nd);
if (unlikely(error))
goto out_filp2;
goto out_filp;
error = -ELOOP;
if (!(nd.flags & LOOKUP_FOLLOW)) {
if (nd.inode->i_op->follow_link)
goto out_path2;
goto out_path;
}
error = -ENOTDIR;
if (nd.flags & LOOKUP_DIRECTORY) {
if (!nd.inode->i_op->lookup)
goto out_path2;
goto out_path;
}
audit_inode(pathname, nd.path.dentry);
filp = finish_open(&nd, open_flag, acc_mode);
out2:
release_open_intent(&nd);
return filp;

out_path2:
path_put(&nd.path);
out_filp2:
filp = ERR_PTR(error);
goto out2;

creat:
/* OK, have to create the file. Find the parent. */
error = path_init_rcu(dfd, pathname,
Expand Down
8 changes: 2 additions & 6 deletions trunk/fs/proc/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
static void proc_evict_inode(struct inode *inode)
{
struct proc_dir_entry *de;
struct ctl_table_header *head;

truncate_inode_pages(&inode->i_data, 0);
end_writeback(inode);
Expand All @@ -39,11 +38,8 @@ static void proc_evict_inode(struct inode *inode)
de = PROC_I(inode)->pde;
if (de)
pde_put(de);
head = PROC_I(inode)->sysctl;
if (head) {
rcu_assign_pointer(PROC_I(inode)->sysctl, NULL);
sysctl_head_put(head);
}
if (PROC_I(inode)->sysctl)
sysctl_head_put(PROC_I(inode)->sysctl);
}

struct vfsmount *proc_mnt;
Expand Down
7 changes: 2 additions & 5 deletions trunk/fs/proc/proc_sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -408,18 +408,15 @@ static int proc_sys_compare(const struct dentry *parent,
const struct dentry *dentry, const struct inode *inode,
unsigned int len, const char *str, const struct qstr *name)
{
struct ctl_table_header *head;
/* Although proc doesn't have negative dentries, rcu-walk means
* that inode here can be NULL */
/* AV: can it, indeed? */
if (!inode)
return 1;
return 0;
if (name->len != len)
return 1;
if (memcmp(name->name, str, len))
return 1;
head = rcu_dereference(PROC_I(inode)->sysctl);
return !head || !sysctl_is_seen(head);
return !sysctl_is_seen(PROC_I(inode)->sysctl);
}

static const struct dentry_operations proc_sys_dentry_operations = {
Expand Down
14 changes: 4 additions & 10 deletions trunk/include/linux/sysctl.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#include <linux/kernel.h>
#include <linux/types.h>
#include <linux/compiler.h>
#include <linux/rcupdate.h>

struct completion;

Expand Down Expand Up @@ -1038,15 +1037,10 @@ struct ctl_table_root {
struct ctl_table trees. */
struct ctl_table_header
{
union {
struct {
struct ctl_table *ctl_table;
struct list_head ctl_entry;
int used;
int count;
};
struct rcu_head rcu;
};
struct ctl_table *ctl_table;
struct list_head ctl_entry;
int used;
int count;
struct completion *unregistering;
struct ctl_table *ctl_table_arg;
struct ctl_table_root *root;
Expand Down
15 changes: 5 additions & 10 deletions trunk/kernel/sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,9 @@ static int sysrq_sysctl_handler(ctl_table *table, int write,
static struct ctl_table root_table[];
static struct ctl_table_root sysctl_table_root;
static struct ctl_table_header root_table_header = {
{{.count = 1,
.count = 1,
.ctl_table = root_table,
.ctl_entry = LIST_HEAD_INIT(sysctl_table_root.default_set.list),}},
.ctl_entry = LIST_HEAD_INIT(sysctl_table_root.default_set.list),
.root = &sysctl_table_root,
.set = &sysctl_table_root.default_set,
};
Expand Down Expand Up @@ -1567,16 +1567,11 @@ void sysctl_head_get(struct ctl_table_header *head)
spin_unlock(&sysctl_lock);
}

static void free_head(struct rcu_head *rcu)
{
kfree(container_of(rcu, struct ctl_table_header, rcu));
}

void sysctl_head_put(struct ctl_table_header *head)
{
spin_lock(&sysctl_lock);
if (!--head->count)
call_rcu(&head->rcu, free_head);
kfree(head);
spin_unlock(&sysctl_lock);
}

Expand Down Expand Up @@ -1953,10 +1948,10 @@ void unregister_sysctl_table(struct ctl_table_header * header)
start_unregistering(header);
if (!--header->parent->count) {
WARN_ON(1);
call_rcu(&header->parent->rcu, free_head);
kfree(header->parent);
}
if (!--header->count)
call_rcu(&header->rcu, free_head);
kfree(header);
spin_unlock(&sysctl_lock);
}

Expand Down

0 comments on commit a4d3cd5

Please sign in to comment.