Skip to content

Commit

Permalink
goldfish: fix sparse warnings
Browse files Browse the repository at this point in the history
drivers/tty/goldfish.c:160:46: warning: Using plain integer as NULL pointer
drivers/tty/goldfish.c:320:22: warning: Using plain integer as NULL pointer

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Fabian Frederick authored and Greg Kroah-Hartman committed Nov 6, 2014
1 parent 0df1f24 commit a4dc923
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/tty/goldfish.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ static int goldfish_tty_console_setup(struct console *co, char *options)
{
if ((unsigned)co->index > goldfish_tty_line_count)
return -ENODEV;
if (goldfish_ttys[co->index].base == 0)
if (!goldfish_ttys[co->index].base)
return -ENODEV;
return 0;
}
Expand Down Expand Up @@ -317,7 +317,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
unregister_console(&qtty->console);
tty_unregister_device(goldfish_tty_driver, pdev->id);
iounmap(qtty->base);
qtty->base = 0;
qtty->base = NULL;
free_irq(qtty->irq, pdev);
goldfish_tty_current_line_count--;
if (goldfish_tty_current_line_count == 0)
Expand Down

0 comments on commit a4dc923

Please sign in to comment.